GeometricDetExtra, PGeometricDetExtra schema removal #31729

vargasa · 2020-10-09T14:16:46Z

PR description:

Addresses #31567

FYI: @ianna, @ghugo83, @cvuosalo

cmsbuild · 2020-10-09T14:17:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-09T14:23:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31729/18927

This PR adds an extra 72KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31729/18927/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31729/18927/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-09T14:33:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-09T14:40:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31729/18929

This PR adds an extra 72KB to repository

cmsbuild · 2020-10-09T14:40:46Z

A new Pull Request was created by @vargasa (Andres Vargas) for master.

It involves the following packages:

CondCore/GeometryPlugins
CondCore/Utilities
CondFormats/GeometryObjects
CondTools/Geometry
Geometry/CaloEventSetup
Geometry/Records
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @yuanchao, @tocheng, @tlampen, @ggovi, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @JanFSchulte, @tocheng, @VinInn, @mmusich, @mtosi, @ebrondol, @seemasharmafnal, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-10-09T15:11:18Z

please test

cmsbuild · 2020-10-09T15:11:41Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9833/console Started: 2020/10/09 17:12

Geometry/TrackerGeometryBuilder/test/ModuleInfo.cc

SLHCUpgradeSimulations/Geometry/test/ModuleInfo_Phase2.cc

mmusich · 2020-10-09T16:11:16Z

-1
@vargasa, if the Global Tags are not cleaned by the record first, I suspect this will fail...

BTW: why have you proceeded without explicit aknowledgement from the DPG?

cmsbuild · 2020-10-09T16:44:12Z

-1

Tested at: 54d75b9

CMSSW: CMSSW_11_2_X_2020-10-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Introduce TrackingEffFromHitPatternClientConfigZeroBias and use it for the trackingZeroBias DQM Harvesting sequence #31713 @mmusich: Introduce TrackingEffFromHitPatternClientConfigZeroBias and use it for the trackingZeroBias DQM Harvesting sequence

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617005/9833/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617005/9833/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617005/9833/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation error when building:

trackerTopology
--- Registered EDM Plugin: GeometryTrackerNumberingBuilderPlugins
Entering library rule at src/Geometry/TrackerNumberingBuilder/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerNumberingBuilder/test/ModuleNumbering.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerNumberingBuilder/test/ModuleNumbering.cc:41:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/poison/Geometry/TrackerNumberingBuilder/interface/CmsTrackerDebugNavigator.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerNumberingBuilder/test/ModuleNumbering.cc:41:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/poison/Geometry/TrackerNumberingBuilder/interface/CmsTrackerDebugNavigator.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.

Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerGeometryBuilder/test/phase1PixelTopology_t.cpp
Entering library rule at src/Geometry/TrackerGeometryBuilder/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerGeometryBuilder/test/GeoHierarchyTest.cc
Entering library rule at src/Geometry/TrackerGeometryBuilder/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerGeometryBuilder/test/ModuleInfo.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerGeometryBuilder/test/ModuleInfo.cc:168:28: error: no member named 'geographicalID' in 'GeometricDet'; did you mean 'geographicalId'?
    int subdetid = module->geographicalID().subdetId();
                           ^~~~~~~~~~~~~~
                           geographicalId
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-09-1100/src/Geometry/TrackerNumberingBuilder/interface/GeometricDet.h:96:16: note: 'geographicalId' declared here
  const DetId& geographicalId() const { return geographicalID_; }

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Introduce TrackingEffFromHitPatternClientConfigZeroBias and use it for the trackingZeroBias DQM Harvesting sequence #31713 @mmusich: Introduce TrackingEffFromHitPatternClientConfigZeroBias and use it for the trackingZeroBias DQM Harvesting sequence

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617005/9833/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617005/9833/git-merge-result

cmsbuild · 2020-10-09T16:44:16Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-10-17T21:40:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abcf69/10049/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543752
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543720
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

christopheralanwest · 2020-10-17T22:12:39Z

Should the "Draft" status of this PR be removed?

ianna · 2020-10-18T07:41:38Z

+1

silviodonato · 2020-10-18T12:38:52Z

urgent
I have merged #31780 too early

kpedro88 · 2020-10-18T17:56:50Z

+upgrade

christopheralanwest · 2020-10-18T17:59:34Z

+alca

silviodonato · 2020-10-19T08:34:26Z

Do you have any comments? @ggovi

silviodonato · 2020-10-19T15:07:43Z

merge
@ggovi I have to merge this PR to fix a failure in a unit test which makes fail all PR tests.
Please let us know if you have any comments/objections on this PR

silviodonato · 2020-10-20T08:27:03Z

We are getting several errors after having merged this PR
see #31869

cmsbuild added this to the CMSSW_11_2_X milestone Oct 9, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Oct 9, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 9, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2020

mmusich reviewed Oct 9, 2020

View reviewed changes

Geometry/TrackerGeometryBuilder/test/ModuleInfo.cc Outdated Show resolved Hide resolved

mmusich reviewed Oct 9, 2020

View reviewed changes

SLHCUpgradeSimulations/Geometry/test/ModuleInfo_Phase2.cc Outdated Show resolved Hide resolved

cmsbuild added comparison-available and removed comparison-pending labels Oct 17, 2020

vargasa marked this pull request as ready for review October 17, 2020 23:11

cmsbuild added geometry-approved and removed geometry-pending labels Oct 18, 2020

cmsbuild added the urgent label Oct 18, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 18, 2020

cmsbuild added alca-approved and removed alca-pending labels Oct 18, 2020

christopheralanwest mentioned this pull request Oct 19, 2020

Added PSetTemplate to allow description of a PSet #31841

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 19, 2020

cmsbuild merged commit bc6fe4a into cms-sw:master Oct 19, 2020

ianna mentioned this pull request Oct 20, 2020

Update DD4Hep to latest commit on master cms-sw/cmsdist#6315

Merged

silviodonato mentioned this pull request Oct 20, 2020

Exception while attempting to load plugin PGeometricDetExtraRcd@NewProxy #31869

Closed

mmusich mentioned this pull request Oct 20, 2020

fix stray Global Tags post GeometricDetExtra Migration #31871

Merged

vargasa mentioned this pull request Oct 21, 2020

[Geometry][Tracker][RECO] Legacy GeometricDetExtra to be removed #31567

Closed

mmusich mentioned this pull request Oct 21, 2020

Switch payloads of new phase 2 tau ID to GT #31866

Merged

makortel mentioned this pull request Oct 28, 2020

Get UTM 0.8.1 version cms-sw/cmsdist#6338

Merged

mmusich mentioned this pull request Apr 28, 2021

Remove GEMELMap from CMSSW, its an old format that's not used #33524

Closed

GeometricDetExtra, PGeometricDetExtra schema removal #31729

GeometricDetExtra, PGeometricDetExtra schema removal #31729

Uh oh!

Conversation

vargasa commented Oct 9, 2020

PR description:

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

ianna commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmusich commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 9, 2020

Uh oh!

cmsbuild commented Oct 17, 2020

Uh oh!

christopheralanwest commented Oct 17, 2020

Uh oh!

ianna commented Oct 18, 2020

Uh oh!

silviodonato commented Oct 18, 2020

Uh oh!

kpedro88 commented Oct 18, 2020

Uh oh!

christopheralanwest commented Oct 18, 2020

Uh oh!

silviodonato commented Oct 19, 2020

Uh oh!

silviodonato commented Oct 19, 2020

Uh oh!

silviodonato commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cmsbuild commented Oct 9, 2020 •

edited

Loading