-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a0881f5
added Vertex Recovery option for HI
abaty 9f7ab42
added code format and checks
abaty 21e5a2b
made import more specific to avoid bugs and included default param in…
abaty f473f65
fixed conflict from recent merges
abaty f55dc9b
Merge branch 'master' into miniAOD_VtxRecovery
abaty 0b5056b
added assert and tweaked configs for vertex recovery
abaty ee65572
Merge branch 'miniAOD_VtxRecovery' of https://github.com/abaty/cmssw …
abaty 280b0c5
fixes for config error and switch to exception error message
abaty d552e8b
small change to pass code checks
abaty 7d0d84c
Merge branch 'master' into miniAOD_VtxRecovery
abaty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from RecoVertex.PrimaryVertexProducer.OfflinePrimaryVertices_cfi import offlinePrimaryVertices | ||
|
|
||
| offlinePrimaryVerticesRecovery = offlinePrimaryVertices.clone( | ||
|
|
||
| isRecoveryIteration = True, | ||
| recoveryVtxCollection = "offlinePrimaryVertices", | ||
|
|
||
| TkFilterParameters = dict( | ||
| maxNormalizedChi2 = 999.0, | ||
| minPixelLayersWithHits= 0, | ||
| minSiliconLayersWithHits = 0, | ||
| maxD0Significance = 999.0, | ||
| minPt = 0.0, | ||
| maxEta = 999.0, | ||
| trackQuality = "any" | ||
| ), | ||
|
|
||
| TkClusParameters = dict( | ||
| algorithm = "gap", | ||
| TkGapClusParameters = cms.PSet( | ||
| zSeparation = cms.double(1.0) | ||
| ) | ||
| ), | ||
|
|
||
| vertexCollections = [offlinePrimaryVertices.vertexCollections[0].clone()] | ||
| ) | ||
|
|
||
| from PhysicsTools.PatAlgos.slimming.offlineSlimmedPrimaryVertices_cfi import offlineSlimmedPrimaryVertices | ||
| offlineSlimmedPrimaryVerticesRecovery = offlineSlimmedPrimaryVertices.clone( | ||
| src = "offlinePrimaryVerticesRecovery", | ||
| score = None | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same should be done for all available algorithms or there should be an assert in the constructor that only one algorithm exists if
isRecoveryIterationis setThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added an assert() in the constructor. For our purposes of event selection, we only need one algorithm run for the recovery.