-
Notifications
You must be signed in to change notification settings - Fork 14
alpaka backend: Do not add self dependency if package/src generates edm plugin #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dm plugin instead of shared lib
|
test parameters:
|
|
please test |
|
A new Pull Request was created by @smuzaffar for branch scramv3. @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Thanks @smuzaffar! I noticed those warnings in a local area and was puzzled what was going on (but didn't look deeper at all) |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b336/44301/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Build rules currently force add dependency on main shared library ( generated from package/src directory) . This causes SCRAM build time warnings like [a] when the package generates EDM plugimn instead of shared library.
This change now only add the dependency if the main package/src generates/exports a shared lib.
FYI @fwyzard @makortel
[a]