Skip to content

Conversation

@smuzaffar
Copy link
Contributor

Build rules currently force add dependency on main shared library ( generated from package/src directory) . This causes SCRAM build time warnings like [a] when the package generates EDM plugimn instead of shared library.

This change now only add the dependency if the main package/src generates/exports a shared lib.

FYI @fwyzard @makortel
[a]

****WARNING: Invalid tool RecoLocalCalo/HcalRecProducers. Please fix src/RecoLocalCalo/HcalRecProducers/plugins/BuildFile.xml file.
****WARNING: Invalid tool RecoLocalTracker/SiPixelClusterizer. Please fix src/RecoLocalTracker/SiPixelClusterizer/plugins/BuildFile.xml file.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch scramv3.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2025

cms-bot internal usage

@makortel
Copy link

Thanks @smuzaffar! I noticed those warnings in a local area and was puzzled what was going on (but didn't look deeper at all)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b336/44301/summary.html
COMMIT: 4aa337e
CMSSW: CMSSW_15_1_X_2025-02-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/114/44301/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b336/44301/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0b336/44301/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 168 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66675 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4019507
  • DQMHistoTests: Total failures: 500904
  • DQMHistoTests: Total nulls: 269
  • DQMHistoTests: Total successes: 3518314
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.6630000000000003 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 3.641 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): -0.464 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.162 KiB SiStrip/MechanicalView
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit edd6ec0 into scramv3 Feb 11, 2025
10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants