-
Notifications
You must be signed in to change notification settings - Fork 207
Update alpaka to 1.3.0 #9944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alpaka to 1.3.0 #9944
Conversation
|
enable gpu |
|
A new Pull Request was created by @fwyzard for branch IB/CMSSW_15_1_X/master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
test parameters:
|
|
please test |
|
I was curious to see the new features since 1.2.0. Is this PR a pre-release test? |
|
Hi @slava77, alpaka 1.3.0 is a bug-fix release, there are no new features. alpaka 2.0.0 is the current feature branch, but I already tested that CMSSW does not build cleanly with it, so I will follow up next month. |
|
-1 Failed Tests: cudaUnitTests rocmUnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: CUDA Unit TestsI found 1 errors in the following unit tests: ---> test testHeterogeneousCoreCUDACoreStreamEvent had ERRORS ROCm Unit TestsI found 3 errors in the following unit tests: ---> test testRocmSoALayoutAndView_t had ERRORS ---> test alpakaTestBufferROCmAsync had ERRORS ---> test alpakaTestRadixSortROCmAsync had ERRORS Comparison SummarySummary:
CUDA Comparison SummarySummary:
ROCM Comparison SummarySummary:
|
|
Mhm, the ROCm failures are known, but the CUDA one is unexpected. |
514f909 to
cb6addf
Compare
cb6addf to
06884ba
Compare
|
Pull request #9944 was updated. |
This is primarily a bugfix release with a focus on SYCL changes. It addresses several SYCL-specific issues, including fixes to the parallel loop patterns for the Intel FPGA SYCL backend, corrections to the SYCL index order, and updates to template arguments of SYCL buffer specializations. Additionally, the release includes changes to SYCL attributes and protections for __SYCL_TARGET macros. Overall, this release aims to improve stability and performance, particularly for SYCL-related functionalities.
06884ba to
9add34a
Compare
|
Pull request #9944 was updated. |
|
Alpaka 1.3.0 has been officially released, so I've updated the PR to match. |
|
please test |
|
-1 Failed Tests: UnitTests rocmUnitTests Unit TestsI found 1 errors in the following unit tests: ---> test BUFU_TEST had ERRORS ROCm Unit TestsI found 0 errors in the following unit tests: Comparison SummarySummary:
CUDA Comparison SummarySummary:
ROCM Comparison SummarySummary:
|
|
Both failures seem pretty much unrelated to this PR. @smuzaffar do you know if this failure
means the NGT image or the CI image need to be updated ? |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0955d5/47937/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
please test To check the new GPU architectures, as well. |
|
@smuzaffar @iarspider @ftenchini @mandrenguyen as I will miss the release planning meeting next week, let me ask here: can we have this merged for CMSSW 15.1.x to have it in the final release ? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0955d5/47996/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
can we merge this in 16.0.x ? |
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
354d393
into
cms-sw:IB/CMSSW_16_0_X/master
This is primarily a bugfix release with a focus on SYCL changes.
It addresses several SYCL-specific issues, including fixes to the parallel loop patterns for the Intel FPGA SYCL backend, corrections to the SYCL index order, and updates to template arguments of SYCL buffer specializations.
Additionally, the release includes changes to SYCL attributes and protections for
__SYCL_TARGETmacros.Overall, this release aims to improve stability and performance, particularly for SYCL-related functionalities.