[Do not merge]Build root/llvm with std=cpp17

[smuzaffar]

Testing ROOT 6.32 build patched to build internal llvm with c++17

[smuzaffar]

test parameters:

• full_cmssw = true

[smuzaffar]

please test

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test for el8_aarch64_gcc12

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46527/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Phase2-hgx364G Make coherent definitions of Wafer Size and Nominal Wafer Size for several scenarios using HGCal cmssw#48222

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/git-merge-result

Comparison Summary

Summary:

• You potentially removed 158 lines from the logs
• Reco comparison results: 8914 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4041180
• DQMHistoTests: Total failures: 71998
• DQMHistoTests: Total nulls: 110
• DQMHistoTests: Total successes: 3969052
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: found differences in 2 / 48 workflows

[cmsbuild]

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-02-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46530/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Phase2-hgx364G Make coherent definitions of Wafer Size and Nominal Wafer Size for several scenarios using HGCal cmssw#48222

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

• 29634.75

----- Begin Fatal Exception 04-Jun-2025 04:17:17 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

• 29834.999

----- Begin Fatal Exception 04-Jun-2025 04:22:04 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

• 24834.911

----- Begin Fatal Exception 04-Jun-2025 04:27:28 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 29634.911
• 29634.0

[smuzaffar]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46532/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 157 lines from the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4041180
• DQMHistoTests: Total failures: 70
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4041090
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@makortel , this PR applies part of #9910 (only interpreter/CMakeLists.txt change to force build llvm with c++17) to existing ROOT 6.32. DQM Comparison differences in #9910 (comment) are our usual differences. Should we try to integrate it in DEVEL IBs to see how this change behaves when relvals are run in threaded mode?

[makortel]

Should we try to integrate it in DEVEL IBs to see how this change behaves when relvals are run in threaded mode?

Sure, testing in DEVEL sounds good. (sigh, but it is what it is)

[smuzaffar]

@makortel , looks like latest GCC 13.3 changes allow us to build ROOT 6.32 without force building llvm with c++17. PR tests #9914 (which is using the tip of gcc 13 branch) ran successfully.

[makortel]

looks like latest GCC 13.3 changes allow us to build ROOT 6.32 without force building llvm with c++17. PR tests #9914 (which is using the tip of gcc 13 branch) ran successfully.

Nice