Skip to content

ROCM: do not set --gcc-toolchain/--target via toolfile #9895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smuzaffar merged 1 commit into from
May 28, 2025
Merged

ROCM: do not set --gcc-toolchain/--target via toolfile #9895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions scram-tools.file/tools/rocm/env.sh
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions scram-tools.file/tools/rocm/rocm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<tool name="rocm" version="@TOOL_VERSION@" revision="4">
<tool name="rocm" version="@TOOL_VERSION@" revision="5">
<info url="https://rocm.docs.amd.com/en/docs-@TOOL_VERSION@/"/>
<lib name="amdhip64"/>
<lib name="hsa-runtime64"/>
Expand All @@ -12,7 +12,7 @@
</client>
<flags CPPDEFINES="__HIP_PLATFORM_HCC__ __HIP_PLATFORM_AMD__"/>
<flags ROCM_FLAGS="@ROCM_FLAGS@"/>
<flags ROCM_FLAGS="-fgpu-rdc --target=@COMPILER_HOST@ --gcc-toolchain=$(COMPILER_PATH)"/>
<flags ROCM_FLAGS="-fgpu-rdc"/>
%if "%{default_microarch_name}"
%if "%{default_microarch_name}" != "%{min_microarch_name}"
<flags REM_ROCM_HOST_CXXFLAGS="-march=%%"/>
Expand Down