Skip to content

Conversation

@smuzaffar
Copy link
Contributor

As requested cms-sw/cmssw#47953, this PR moves RNTUPLE IBs to following bit stable ROOT 6-36-00-patches branch changes

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/rntuple.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de2fdf/46041/summary.html
COMMIT: a10b01c
CMSSW: CMSSW_15_1_RNTUPLE_X_2025-05-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9851/46041/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de2fdf/46041/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de2fdf/46041/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test testDiMuonBiasesPlotting had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 433 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4038131
  • DQMHistoTests: Total failures: 1428
  • DQMHistoTests: Total nulls: 32
  • DQMHistoTests: Total successes: 4036651
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 37.904 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): 4.246 KiB L1TEMU/L1TdeStage2EMTF
  • DQMHistoSizes: changed ( 145.014,... ): 0.492 KiB L1T/L1TStage2uGT
  • Checked 215 log files, 8 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

ignore tests-rejected with manual-override

Presently test failures are acceptable in RNTUPLE_X IB, and will be investigated further in the IBs.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 13e3f9b into IB/CMSSW_15_1_X/rntuple May 12, 2025
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_1_X/rntuple IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the rntuple-to-use-root636 branch May 12, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants