Skip to content

Conversation

@iarspider
Copy link
Contributor

Changes: root-project/root@cf548e1...6a6ed1a
Some updates for RDataFrame

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_15_1_X/root636.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2025

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e1f2e/46040/summary.html
COMMIT: 1375afc
CMSSW: CMSSW_15_1_ROOT636_X_2025-05-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9850/46040/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e1f2e/46040/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e1f2e/46040/git-merge-result

Comparison Summary

Summary:

  • You potentially added 240 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 766 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4038131
  • DQMHistoTests: Total failures: 1541
  • DQMHistoTests: Total nulls: 32
  • DQMHistoTests: Total successes: 4036538
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 37.904 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): 4.246 KiB L1TEMU/L1TdeStage2EMTF
  • DQMHistoSizes: changed ( 145.014,... ): 0.492 KiB L1T/L1TStage2uGT
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 5 / 48 workflows

@smuzaffar
Copy link
Contributor

smuzaffar commented May 12, 2025

+externals

good to go in for ROOT636 IBs

@smuzaffar smuzaffar merged commit b254675 into cms-sw:IB/CMSSW_15_1_X/root636 May 12, 2025
9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_1_X/root636 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants