-
Notifications
You must be signed in to change notification settings - Fork 207
Update tensorflow 2.17.0 to build OneDNN objects with -fno-omit-frame-pointer #9731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @gartung for branch IB/CMSSW_15_1_X/tf. @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
b2a2f55 to
0df1ef3
Compare
|
Pull request #9731 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44826/summary.html Comparison SummarySummary:
|
|
please test with cms-sw/cms-bot#2449 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44892/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
@smuzaffar Is it possible to make a CMSSW_15_1_TF prerelease with this build of Tensforflow 2.17.0? I want to have an install of Tensorflow 2.17.0 with DNNL_ENABLE_MEM_DEBUG enabled that is on /cvmfs/cms.cern.ch so it does not go away. I can then configure profiling jobs with that build of Tensorflow. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44921/summary.html Comparison SummarySummary:
|
3b7acbf to
a34b8f1
Compare
|
Pull request #9731 was updated. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45046/summary.html External BuildI found compilation error when building: + BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3 --config=opt --cxxopt=-std=c++20 --host_cxxopt=-std=c++20 -j 16'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3 --config=opt --cxxopt=-std=c++20 --host_cxxopt=-std=c++20 -j 16 --config=noaws --config=nogcp --config=nohdfs --config=nonccl'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU: line 100: syntax error near unexpected token `('
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU (%build)
RPM build errors:
line 42: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow-sources+2.17.0-38513881e42e33c7ea968b084891856b
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU (%build)
|
a34b8f1 to
ac42767
Compare
|
Pull request #9731 was updated. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45047/summary.html External BuildI found compilation error when building: Requested to quit.
Requested to quit.
* The action "build-external+tensorflow-sources+2.17.0-146a36ee906be09826b93abae9f29505" was not completed successfully because Failed to build tensorflow-sources. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tensorflow-sources/2.17.0-146a36ee906be09826b93abae9f29505/log. Final lines of the log file:
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
external/local_xla/xla/service/cpu/onednn_matmul.cc: In function 'void xla::cpu::__xla_cpu_runtime_OneDnnMatMulReorder(void*, void**)':
external/local_xla/xla/service/cpu/onednn_matmul.cc:359:68: error: cannot convert 'std::unique_ptr::pointer' {aka 'tsl::OneDnnThreadPool*'} to 'dnnl::threadpool_interop::threadpool_iface*'
359 | auto onednn_stream = MakeOneDnnStream(cpu_engine, thread_pool.get());
| ~~~~~~~~~~~~~~~^~
| |
| std::unique_ptr::pointer {aka tsl::OneDnnThreadPool*}
external/local_xla/xla/service/cpu/onednn_util.h:59:49: note: initializing argument 2 of 'dnnl::stream xla::cpu::MakeOneDnnStream(const dnnl::engine&, dnnl::threadpool_interop::threadpool_iface*)'
|
|
Pull request #9731 was updated. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45079/summary.html External BuildI found compilation error when building: File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/py3-wheel/0.40.0-26985326cea1585bb04c44d35ac9b817/lib/python3.9/site-packages/wheel/wheelfile.py", line 47, in __init__ ZipFile.__init__(self, file, mode, compression=compression, allowZip64=True) File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/python3/3.9.14-ccc34bac15aa449b4c76ba24d02d2fd7/lib/python3.9/zipfile.py", line 1248, in __init__ self.fp = io.open(file, filemode) FileNotFoundError: [Errno 2] No such file or directory: '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tensorflow-sources/2.17.0-b6792ae7a36a5a3faf8003db0c811655/tensorflow-2.17.0*-cp39-cp39-linux_x86_64.whl' error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YutBsc (%install) RPM build errors: line 42: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow+2.17.0-63c02fcda90b26741fae0dec4b06f74f Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YutBsc (%install) |
Includes changes from these pull requests
cms-externals/tensorflow#13
cms-externals/tensorflow#18
Suggested change from this OneDNN issue
uxlfoundation/oneDNN#1232