Skip to content

Conversation

@gartung
Copy link
Member

@gartung gartung commented Mar 5, 2025

Includes changes from these pull requests
cms-externals/tensorflow#13
cms-externals/tensorflow#18

Suggested change from this OneDNN issue
uxlfoundation/oneDNN#1232

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

A new Pull Request was created by @gartung for branch IB/CMSSW_15_1_X/tf.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

cms-bot internal usage

@gartung gartung force-pushed the IB/CMSSW_15_1_X/tf branch from b2a2f55 to 0df1ef3 Compare March 5, 2025 17:44
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

Pull request #9731 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44826/summary.html
COMMIT: 0df1ef3
CMSSW: CMSSW_15_1_TF_X_2025-03-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9731/44826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 212 lines to the logs
  • Reco comparison results: 7193 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920287
  • DQMHistoTests: Total failures: 34927
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3885337
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.041 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): -0.001 KiB HLT/Filters
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Mar 10, 2025

please test with cms-sw/cms-bot#2449

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44892/summary.html
COMMIT: 0df1ef3
CMSSW: CMSSW_15_1_TF_X_2025-03-04-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9731/44892/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44892/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44892/git-merge-result

Comparison Summary

Summary:

  • You potentially added 169 lines to the logs
  • Reco comparison results: 7197 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920287
  • DQMHistoTests: Total failures: 34925
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3885339
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.12100000000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): 0.007 KiB HLT/Filters
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Mar 11, 2025

@smuzaffar Is it possible to make a CMSSW_15_1_TF prerelease with this build of Tensforflow 2.17.0? I want to have an install of Tensorflow 2.17.0 with DNNL_ENABLE_MEM_DEBUG enabled that is on /cvmfs/cms.cern.ch so it does not go away. I can then configure profiling jobs with that build of Tensorflow.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/44921/summary.html
COMMIT: 0df1ef3
CMSSW: CMSSW_15_1_TF_X_2025-03-11-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9731/44921/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 218 lines to the logs
  • Reco comparison results: 7185 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 34923
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3885354
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.051 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #9731 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45046/summary.html
COMMIT: a34b8f1
CMSSW: CMSSW_15_1_TF_X_2025-03-18-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9731/45046/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3 --config=opt --cxxopt=-std=c++20 --host_cxxopt=-std=c++20 -j 16'
+ BAZEL_OPTS='--batch --output_user_root ../build --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED --host_jvm_args=--add-opens=java.base/java.lang=ALL-UNNAMED build -s --verbose_failures --distinct_host_configuration=false --copt=-march=x86-64-v3 --config=opt --cxxopt=-std=c++20 --host_cxxopt=-std=c++20 -j 16 --config=noaws --config=nogcp --config=nohdfs --config=nonccl'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU: line 100: syntax error near unexpected token `('
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU (%build)


RPM build errors:
line 42: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow-sources+2.17.0-38513881e42e33c7ea968b084891856b
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.DdZhiU (%build)


@cmsbuild
Copy link
Contributor

Pull request #9731 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45047/summary.html
COMMIT: ac42767
CMSSW: CMSSW_15_1_TF_X_2025-03-18-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9731/45047/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
* The action "build-external+tensorflow-sources+2.17.0-146a36ee906be09826b93abae9f29505" was not completed successfully because Failed to build tensorflow-sources. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tensorflow-sources/2.17.0-146a36ee906be09826b93abae9f29505/log. Final lines of the log file:
|     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
external/local_xla/xla/service/cpu/onednn_matmul.cc: In function 'void xla::cpu::__xla_cpu_runtime_OneDnnMatMulReorder(void*, void**)':
external/local_xla/xla/service/cpu/onednn_matmul.cc:359:68: error: cannot convert 'std::unique_ptr::pointer' {aka 'tsl::OneDnnThreadPool*'} to 'dnnl::threadpool_interop::threadpool_iface*'
359 |   auto onednn_stream = MakeOneDnnStream(cpu_engine, thread_pool.get());
|                                                     ~~~~~~~~~~~~~~~^~
|                                                                    |
|                                                                    std::unique_ptr::pointer {aka tsl::OneDnnThreadPool*}
external/local_xla/xla/service/cpu/onednn_util.h:59:49: note:   initializing argument 2 of 'dnnl::stream xla::cpu::MakeOneDnnStream(const dnnl::engine&, dnnl::threadpool_interop::threadpool_iface*)'


@cmsbuild
Copy link
Contributor

Pull request #9731 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26d192/45079/summary.html
COMMIT: 11875d9
CMSSW: CMSSW_15_1_TF_X_2025-03-18-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9731/45079/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/py3-wheel/0.40.0-26985326cea1585bb04c44d35ac9b817/lib/python3.9/site-packages/wheel/wheelfile.py", line 47, in __init__
ZipFile.__init__(self, file, mode, compression=compression, allowZip64=True)
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/python3/3.9.14-ccc34bac15aa449b4c76ba24d02d2fd7/lib/python3.9/zipfile.py", line 1248, in __init__
self.fp = io.open(file, filemode)
FileNotFoundError: [Errno 2] No such file or directory: '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tensorflow-sources/2.17.0-b6792ae7a36a5a3faf8003db0c811655/tensorflow-2.17.0*-cp39-cp39-linux_x86_64.whl'
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YutBsc (%install)


RPM build errors:
line 42: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tensorflow+2.17.0-63c02fcda90b26741fae0dec4b06f74f
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.YutBsc (%install)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants