-
Notifications
You must be signed in to change notification settings - Fork 207
Rivet 4.0.1 and YODA 2.0.1 #9481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @mseidel42 for branch IB/CMSSW_14_2_X/master. @aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-rivet-list had ERRORS Comparison SummarySummary:
|
|
something wrong here, unit test is using rivet from |
|
Hi Shahzad, I pulled the user test area, is it possible to force it to use the rivet python libs in |
|
looks like PYTHONPATH includes both |
|
this shows that both river python path are add. We should only add the default one |
|
please test for CMSSW_14_2_DEVEL_X |
|
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 145 errors in the following unit tests: ---> test testAlignmentStats had ERRORS ---> test test_ZMuMuMassConstraintParameterFinder had ERRORS ---> test test_MilleZmm had ERRORS and more ... RelValsThe relvals timed out after 4 hours. AddOn Tests
|
|
please test for CMSSW_14_2_DEVEL_X |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 2 errors in the following unit tests: ---> test testPrintTkMaps had ERRORS ---> test test-rivet-list had ERRORS Comparison SummarySummary:
|
|
please test for CMSSW_14_2_DEVEL_X |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found 1 errors in the following unit tests: ---> test test-rivet-list had ERRORS RelValsThe relvals timed out after 4 hours. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f23985/42499/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
test parameters:
|
|
please test |
|
please test for CMSSW_14_2_MULTIARCHS_X |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
|
+externals looks good |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test test-rivet-list had ERRORS Comparison SummarySummary:
|
This failure is visible in IBs. Maybe it's random? |
|
@makortel , yes this look like random. It is failing randomly for different IBs. I am looking in to it |
|
@mseidel42 , looks like issue is with [a] |
|
looks like https://gitlab.com/hepcedar/rivet/-/commit/8869db87de9d6c8cfe57e16b2c1469c3cf3b38bd has added the protection for invalid reads |
|
hopefully #9495 should fix this failure |
Source1patch as it is included in Rivet 4.0.1script_generator.pytopython3, see https://gitlab.com/hepcedar/rivet/-/issues/494