Skip to content

Conversation

@iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

Do we need any geant4 data updates to go with this ?

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9297 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ee4a/40362/summary.html
COMMIT: ef8b36c
CMSSW: CMSSW_14_1_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9297/40362/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ee4a/40362/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ee4a/40362/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 2138 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 48769 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246798
  • DQMHistoTests: Total failures: 380710
  • DQMHistoTests: Total nulls: 220
  • DQMHistoTests: Total successes: 2865848
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.4000000000000001 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.389 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.596 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.660 KiB SiStrip/MechanicalView
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 13 / 45 workflows

@smuzaffar
Copy link
Contributor

Please test

@civanch
Copy link
Contributor

civanch commented Jul 13, 2024

@smuzaffar , regression is not expected but statistically results well in agreement with the baseline. Our validation results are at https://indico.cern.ch/event/1438083/contributions/6051394/attachments/2895892/5077406/Sim-Talk194.pdf

Updated datafiles are not needed for this patch release.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ee4a/40369/summary.html
COMMIT: ef8b36c
CMSSW: CMSSW_14_1_X_2024-07-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9297/40369/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 52350 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 384171
  • DQMHistoTests: Total nulls: 297
  • DQMHistoTests: Total successes: 2960606
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.4000000000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.389 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.182 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.596 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.660 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 14 / 46 workflows

@smuzaffar
Copy link
Contributor

assign simulation

@cmsbuild
Copy link
Contributor

New categories assigned: simulation

@civanch,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar
Copy link
Contributor

@civanch , any objection on including this ? if not can you please sign it?

@civanch
Copy link
Contributor

civanch commented Jul 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit bddf76c into IB/CMSSW_14_1_X/master Jul 15, 2024
@smuzaffar smuzaffar deleted the master-geant4-11.2.2 branch July 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants