Skip to content

Conversation

@aandvalenzuela
Copy link
Contributor

ROOT version is still 6.31.01.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_14_1_X/rootmaster.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c414d5/37300/summary.html
COMMIT: 3d4de74
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8995/37300/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-07-2300/src/FWCore/Framework/interface/LuminosityBlockForOutput.h:21,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-07-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:8,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-07-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h: In instantiation of 'std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = ROOT::Experimental::RNTupleWriter; _Args = {unique_ptr >, unique_ptr >}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-07-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:26:45:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h:1065:30: error: 'ROOT::Experimental::RNTupleWriter::RNTupleWriter(std::unique_ptr, std::unique_ptr)' is private within this context
 1065 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-07-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:14:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-8a48411e094c20d47357ee8adfe84470/include/ROOT/RNTuple.hxx:460:4: note: declared private here
  460 |    RNTupleWriter(std::unique_ptr model, std::unique_ptr sink);


@makortel
Copy link
Contributor

makortel commented Feb 8, 2024

@Dr15Jones mentioned me earlier that ROOT had changed (broken) the RNTuple API again, I guess the compilation failure is caused by that. Also FYI @dan131riley.

@smuzaffar
Copy link
Contributor

closing in favor of #8999 (which might fail due to RNTuple API changes)

@smuzaffar smuzaffar closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants