Skip to content

[hls] Fix for uninitialized/maybe-uninitialized warnings #8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [14_0_X] Update tag for Configuration-Generator to V01-10-00
merged 1 commit into from
Nov 23, 2023
Merged

[hls] Fix for uninitialized/maybe-uninitialized warnings #8834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions hls-fix-uninitialized.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--- a/include/etc/ap_private.h 2022-05-16 15:05:19.000000000 +0200
+++ b/include/etc/ap_private.h 2023-11-23 14:53:55.052958667 +0100
@@ -1590,7 +1590,7 @@
}

public:
- INLINE ap_private() {
+ INLINE ap_private(): VAL(0) {
set_canary();
clearUnusedBits();
check_canary();
@@ -3302,6 +3302,7 @@
/// for object deserialization (pair this with the static method Read).
INLINE ap_private() {
set_canary();
+ memset(pVal, 0, _AP_N * sizeof(uint64_t));
clearUnusedBits();
check_canary();
}
2 changes: 2 additions & 0 deletions hls.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
%define github_user Xilinx
%define runpath_opts -m examples
Source: git+https://github.com/%{github_user}/HLS_arbitrary_Precision_Types.git?obj=%{branch}/%{tag}&export=%{n}-%{realversion}&output=/%{n}-%{realversion}-%{tag}.tgz
Patch0: hls-fix-uninitialized
Requires: gmake

%prep
%setup -n %{n}-%{realversion}
%patch0 -p1

%build

Expand Down