Skip to content

[12_4_X] bumping up sherpa to 2.2.15#8679

Merged
cmsbuild merged 2 commits intocms-sw:IB/CMSSW_12_4_X/masterfrom
shimashimarin:IB/CMSSW_12_4_X/master
Sep 19, 2023
Merged

[12_4_X] bumping up sherpa to 2.2.15#8679
cmsbuild merged 2 commits intocms-sw:IB/CMSSW_12_4_X/masterfrom
shimashimarin:IB/CMSSW_12_4_X/master

Conversation

@shimashimarin
Copy link

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2023

A new Pull Request was created by @shimashimarin (Jie Xiao) for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df7ea0/34626/summary.html
COMMIT: 5076105
CMSSW: CMSSW_12_4_X_2023-09-03-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8679/34626/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766047
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df7ea0/34655/summary.html
COMMIT: 5076105
CMSSW: CMSSW_12_4_X_2023-09-03-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8679/34655/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

backport of #8450

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@shimashimarin why only backport this to 10.6 and 12.4? What about 12.5, 12.6 and 13.0?

@shimashimarin
Copy link
Author

Hi @smuzaffar, 10.6 and 12.4 are used for current UL and Run3 sample production. If needed, I can make pull requests to backport this to 12.5, 12.6, and 13.0. Please let me know.

@smuzaffar
Copy link
Contributor

assign generators

@rappoccio @antoniovilela feel free to merge it for 12.4

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

New categories assigned: generators

@mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks

@menglu21
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

@rappoccio , @antoniovilela looks like this can also go in next 12.4 release

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit 224c4b4 into cms-sw:IB/CMSSW_12_4_X/master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants