Skip to content

Conversation

@consuegs
Copy link
Contributor

@consuegs consuegs commented May 5, 2023

Follow-up from PR#8442 with openblas library

@consuegs consuegs changed the title Update Millepede, GBL versions, addition of LAPACK solution method with openblasUpdate millepede openblas gbl Update Millepede, GBL versions, addition of LAPACK solution method with openblas May 5, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

A new Pull Request was created by @consuegs for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/32419/summary.html
COMMIT: 766b9e9
CMSSW: CMSSW_13_2_X_2023-05-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8496/32419/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TrajectoryFactoryPlugin.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TrajectoryFactoryBase.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TwoBodyDecayTrajectory.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TwoBodyDecayTrajectoryState.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/ReferenceTrajectory.cc: In member function 'virtual bool ReferenceTrajectory::addMaterialEffectsLocalGbl(const std::vector&, const std::vector&, const std::vector&, const std::vector&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/ReferenceTrajectory.cc:1020:29: error: call of overloaded 'addScatterer(Eigen::CwiseNullaryOp, Eigen::Matrix >&, const Eigen::Inverse >)' is ambiguous
 1020 |       aGblPoint.addScatterer(scatterer, scatPrecision.inverse());
      |       ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gbl/V03-01-00-2daef1dd46a25e8e24e576a21371fcc0/include/GblTrajectory.h:36,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/interface/ReferenceTrajectoryBase.h:103,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/interface/ReferenceTrajectory.h:38,


@consuegs
Copy link
Contributor Author

consuegs commented May 5, 2023

If my understanding is correct, the test fails due to the gbl update commit. Since this was a secondary update to the original scope of the PR of adding the LAPACK solution method with openblas, one proposal could be going back to the gbl version on master. Let me know your thoughts

@smuzaffar
Copy link
Contributor

assign alca
@consuegs , its really up to the requirement, if updated version of GBL is required then I guess we need cmssw update to go with it.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

New categories assigned: alca

@francescobrivio,@saumyaphor4252,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link

tvami commented May 9, 2023

its really up to the requirement, if updated version of GBL is required then I guess we need cmssw update to go with it.

sure if we need it, let's do it, I dont know of other costumer then TkAli who'd get affected

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_13_2_X/master to IB/CMSSW_13_3_X/master July 18, 2023 08:51
@smuzaffar
Copy link
Contributor

@consuegs , should we revert the gbl update or are you going to provide a CMSSW PR to go with newer version of gbl?

@cmsbuild
Copy link
Contributor

Pull request #8496 was updated.

@consuegs
Copy link
Contributor Author

@smuzaffar, I am ok with reverting the gbl update commit and proceeding

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #8496 was updated.

@smuzaffar smuzaffar changed the title Update Millepede, GBL versions, addition of LAPACK solution method with openblas Update Millepede with addition of LAPACK solution method with openblas Sep 25, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/34880/summary.html
COMMIT: 2b5d04f
CMSSW: CMSSW_13_3_X_2023-09-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8496/34880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358022
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test for el8_aarch64_gcc11

@smuzaffar
Copy link
Contributor

please test for el8_ppc64le_gcc11

@smuzaffar
Copy link
Contributor

+externals

@saumyaphor4252 , @perrotta , @consuegs any objections on millepede V04-13-02 update?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/34885/summary.html
COMMIT: 2b5d04f
CMSSW: CMSSW_13_3_X_2023-09-24-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8496/34885/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/34886/summary.html
COMMIT: 2b5d04f
CMSSW: CMSSW_13_3_X_2023-09-24-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8496/34886/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 24900.024900.0_CloseByPGun_CE_H_Coarse_Scint+2026D98/step2_CloseByPGun_CE_H_Coarse_Scint+2026D98.log
  • 24896.024896.0_CloseByPGun_CE_E_Front_120um+2026D98/step2_CloseByPGun_CE_E_Front_120um+2026D98.log
  • 24834.024834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log
Expand to see more relval errors ...

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_13_3_X/master to IB/CMSSW_14_0_X/master November 6, 2023 17:16
@smuzaffar smuzaffar changed the base branch from IB/CMSSW_14_0_X/master to IB/CMSSW_14_1_X/master February 6, 2024 10:22
@mmusich
Copy link
Contributor

mmusich commented Mar 6, 2024

@consuegs is this still relevant, in light of #9053 ? if not please close.

@consuegs consuegs closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants