-
Notifications
You must be signed in to change notification settings - Fork 207
Update Millepede with addition of LAPACK solution method with openblas #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Millepede with addition of LAPACK solution method with openblas #8496
Conversation
|
A new Pull Request was created by @consuegs for branch IB/CMSSW_13_2_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
please test |
|
-1 Failed Tests: Build BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TrajectoryFactoryPlugin.cc
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TrajectoryFactoryBase.cc
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TwoBodyDecayTrajectory.cc
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/TwoBodyDecayTrajectoryState.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/ReferenceTrajectory.cc: In member function 'virtual bool ReferenceTrajectory::addMaterialEffectsLocalGbl(const std::vector&, const std::vector&, const std::vector&, const std::vector&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/src/ReferenceTrajectory.cc:1020:29: error: call of overloaded 'addScatterer(Eigen::CwiseNullaryOp, Eigen::Matrix >&, const Eigen::Inverse >)' is ambiguous
1020 | aGblPoint.addScatterer(scatterer, scatPrecision.inverse());
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gbl/V03-01-00-2daef1dd46a25e8e24e576a21371fcc0/include/GblTrajectory.h:36,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/interface/ReferenceTrajectoryBase.h:103,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-05-1100/src/Alignment/ReferenceTrajectories/interface/ReferenceTrajectory.h:38,
|
|
If my understanding is correct, the test fails due to the gbl update commit. Since this was a secondary update to the original scope of the PR of adding the LAPACK solution method with openblas, one proposal could be going back to the gbl version on master. Let me know your thoughts |
|
assign alca |
|
New categories assigned: alca @francescobrivio,@saumyaphor4252,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
sure if we need it, let's do it, I dont know of other costumer then TkAli who'd get affected |
|
@consuegs , should we revert the |
|
Pull request #8496 was updated. |
|
@smuzaffar, I am ok with reverting the gbl update commit and proceeding |
|
please test |
|
Pull request #8496 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/34880/summary.html Comparison SummarySummary:
|
|
please test for el8_aarch64_gcc11 |
|
please test for el8_ppc64le_gcc11 |
|
+externals @saumyaphor4252 , @perrotta , @consuegs any objections on |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f94bab/34885/summary.html |
|
-1 Failed Tests: RelVals RelVals |
Follow-up from PR#8442 with openblas library