[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins #8298

smuzaffar · 2023-02-08T05:55:45Z

No description provided.

cmsbuild · 2023-02-08T05:56:06Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2023-02-08T05:57:31Z

test parameters:

addpkg = HeterogeneousCore, DataFormats/Portable, HeterogeneousTest, DataFormats/PortableTestObjects
pull_request = CUDA, ROCm and Alpaka-related updates [13.0.x] cmssw#40725

smuzaffar · 2023-02-08T05:57:43Z

please test for CMSSW_13_0_LTO_X

smuzaffar · 2023-02-08T08:58:14Z

please test for CMSSW_13_0_LTO_X/el8_amd64_gcc11

smuzaffar · 2023-02-08T09:20:11Z

please test for CMSSW_13_0_LTO_X

cmsbuild · 2023-02-08T09:20:21Z

Pull request #8298 was updated.

smuzaffar · 2023-02-08T09:22:06Z

please test for CMSSW_13_0_LTO_X/el8_amd64_gcc11

smuzaffar · 2023-02-08T09:22:23Z

please test

smuzaffar · 2023-02-08T09:38:26Z

please test for CMSSW_13_0_LTO_X/el8_aarch64_gcc11

cmsbuild · 2023-02-08T11:11:36Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30497/summary.html
COMMIT: 91e24fe
CMSSW: CMSSW_13_0_LTO_X_2023-02-07-1100/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30497/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update SCRAM: Enable ifcompiler/compiler checking support for Build/Tool files #8297

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30497/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30497/git-merge-result

Build

I found compilation error when building:

>> Entering Package HeterogeneousCore/AlpakaInterface
>> Leaving Package HeterogeneousCore/AlpakaInterface
>> Package HeterogeneousCore/AlpakaInterface built
>> Building alpaka/rocm binary alpakaTestKernelROCmAsync
/data/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/el8_aarch64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/aarch64-redhat-linux-gnu/11.2.1/../../../../aarch64-redhat-linux-gnu/bin/ld: cannot find tmp/el8_aarch64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/alpaka/testKernel.dev.cc.o: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_aarch64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/alpakaTestKernelROCmAsync
gmake: *** [tmp/el8_aarch64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/alpakaTestKernelROCmAsync] Error 1
>> Compiling alpaka/serial /data/cmsbuild/jenkins_a/workspace/ib-run-pr-tests/CMSSW_13_0_LTO_X_2023-02-07-1100/src/HeterogeneousCore/AlpakaInterface/test/alpaka/testKernel.dev.cc
>> Building alpaka/serial binary alpakaTestKernelSerialSync
Copying tmp/el8_aarch64_gcc11/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelSerialSync/alpakaTestKernelSerialSync to productstore area:

cmsbuild · 2023-02-08T12:26:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30494/summary.html
COMMIT: 91e24fe
CMSSW: CMSSW_13_0_X_2023-02-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 27 lines to the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555852
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555827
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-02-08T13:33:51Z

please test for CMSSW_13_0_LTO_X/el8_aarch64_gcc11

cmsbuild · 2023-02-08T13:33:59Z

Pull request #8298 was updated.

smuzaffar · 2023-02-08T14:25:47Z

please test for CMSSW_13_0_LTO_X/el8_amd64_gcc11

cmsbuild · 2023-02-08T15:20:43Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30507/summary.html
COMMIT: 319f8ab
CMSSW: CMSSW_13_0_LTO_X_2023-02-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30507/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

      |                      ^
>> ROCM Device Code Obj tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaTest/plugins/HeterogeneousCoreAlpakaTestPluginsPortableROCmAsync/alpaka/TestAlgo.dev.cc.o.rocm_o 
>> ROCM Device Code Obj tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaTest/plugins/HeterogeneousCoreAlpakaTestPluginsPortableROCmAsync/alpaka/testESAlgoAsync.dev.cc.o.rocm_o 
>> ROCM Device Code library tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaTest/plugins/HeterogeneousCoreAlpakaTestPluginsPortableROCmAsync/libHeterogeneousCoreAlpakaTestPluginsPortableROCmAsync_rocm.a 
>> Building alpaka/rocm edm plugin tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaTest/plugins/HeterogeneousCoreAlpakaTestPluginsPortableROCmAsync/libHeterogeneousCoreAlpakaTestPluginsPortableROCmAsync.so
ld.lld: error: unable to find library -lDataFormatsPortableTestObjectsROCmAsync
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
gmake: *** [tmp/el8_amd64_gcc11/src/HeterogeneousCore/AlpakaTest/plugins/HeterogeneousCoreAlpakaTestPluginsPortableROCmAsync/libHeterogeneousCoreAlpakaTestPluginsPortableROCmAsync.so] Error 1
Leaving library rule at src/HeterogeneousCore/AlpakaTest/plugins
Entering library rule at src/HeterogeneousCore/AlpakaTest/plugins
>> Compiling alpaka/serial edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_LTO_X_2023-02-08-1100/src/HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc

smuzaffar · 2023-02-08T15:52:32Z

please test for CMSSW_13_0_LTO_X/el8_amd64_gcc11

cmsbuild · 2023-02-08T16:32:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30504/summary.html
COMMIT: 319f8ab
CMSSW: CMSSW_13_0_LTO_X_2023-02-07-1100/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30504/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update SCRAM: Enable ifcompiler/compiler checking support for Build/Tool files #8297

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30504/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30504/git-merge-result

smuzaffar · 2023-02-08T16:42:35Z

please test for CMSSW_13_0_LTO_X/el8_aarch64_gcc11

smuzaffar · 2023-02-08T16:42:59Z

please test

smuzaffar · 2023-02-08T16:44:11Z

please test for el9_amd64_gcc11

cmsbuild · 2023-02-08T17:51:08Z

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30518/summary.html
COMMIT: 319f8ab
CMSSW: CMSSW_13_0_X_2023-02-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30518/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30518/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30518/git-merge-result

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoPixelVertexing/PixelVertexFinding
>> Entering Package RecoTauTag/HLTProducers
>> Entering Package RecoTracker/TkSeedGenerator
>> Entering Package FWCore/Version
>> Compile sequence completed for CMSSW CMSSW_13_0_X_2023-02-08-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-08-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/OfflineValidation
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-08-1100/src/Alignment/OfflineValidation/bin/DMRmerge.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-02-08-1100/src/Alignment/OfflineValidation/bin/Options.cc

cmsbuild · 2023-02-08T19:20:39Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30520/summary.html
COMMIT: 319f8ab
CMSSW: CMSSW_13_0_LTO_X_2023-02-08-1100/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30520/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30520/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30520/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testHeterogeneousCoreCUDATestWriteRead had ERRORS
---> test testHeterogeneousCoreAlpakaTestWriteRead had ERRORS
---> test testHeterogeneousCoreAlpakaTestModules had ERRORS
---> test testCudaCheck had ERRORS
and more ...

cmsbuild · 2023-02-09T03:20:52Z

+1

Comparison Summary

Summary:

You potentially added 23 lines to the logs
Reco comparison results: 65466 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555852
DQMHistoTests: Total failures: 151799
DQMHistoTests: Total nulls: 251
DQMHistoTests: Total successes: 3403780
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.4149999999999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.715 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): -1.439 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): 0.885 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.254 KiB SiStrip/MechanicalView
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: found differences in 17 / 47 workflows

cmsbuild · 2023-02-09T03:33:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30519/summary.html
COMMIT: 319f8ab
CMSSW: CMSSW_13_0_X_2023-02-06-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8298/30519/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw [BuildRules] Disable LTO flags for ROCM products #8291
@cms-sw Update SCRAM: Enable ifcompiler/compiler checking support for Build/Tool files #8297
@smuzaffar [GENERATORS] [CLANG] Fixed unused-but-set-variable warnings cmssw#40396
@makortel Fix memory leaks in PortableHostCollection deserialization cmssw#40492
@smuzaffar [GENERATORS] [CLANG] Fixes warnings reported by clang 14 cmssw#40505
@smuzaffar [RECONSTRUCTION] [CLANG] Fixes warnings reported by clang 14 cmssw#40516
@aandvalenzuela [RECONSTRUCTION][CLANG] Fix clang llvm14 warnings cmssw#40611
@fabferro PPS DQM error plots cmssw#40688
@tvami Make _relval GTs symbolic and resnapshot Run3 data GTs cmssw#40692
@bsunanda Phase2-gex146 Rename name of a Phase2 Era to match calorimeter scenario name cmssw#40694
@mmusich Use auto generated cfi files in tracker alignment all-in-one validation tool cmssw#40695
@ChrisMisan Update PPS HPTDC PCL for additional station cmssw#40696
@ChrisMisan Fix unit conversion in PPS Reco LUT shift cmssw#40697
@mmusich Add more fillDescriptions to Alignment/OfflineValidation plugins cmssw#40698
@bsunanda Phase2-sim139 Change scripts to study new Phase2 scenarios in the context of usage and overlaps cmssw#40704
@bsunanda Phase2-gex147 Correct the order of the xml files in defining a scenario - it is a must for dd4hep option cmssw#40705
@AnnikaStein RobustParticleTransformer in DataFormats/BTauReco cmssw#40706
@Soumyatifr diphoton_hlt_filters_added cmssw#40711
@bsunanda Phase2-gex148 Check overlap testing for geometries with HFNose cmssw#40712
@bsunanda Phase2-TB69 Provide the geometry for HGCal Test Beam application cmssw#40713
@jsamudio Moved PFClusterProducer from beginLuminosityBlock to beginRun cmssw#40717
@mmusich [TkAl] Further fixes to JetHT Validation cmssw#40722

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30519/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a760d3/30519/git-merge-result

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 67163 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 153871
DQMHistoTests: Total nulls: 200
DQMHistoTests: Total successes: 3401402
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 8744.498999999998 KiB( 48 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 514.517 KiB CTPPS/TrackingPixel
DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): -0.532 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.488 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.133 KiB SiStrip/MechanicalView
Checked 213 log files, 164 edm output root files, 49 DQM output files

[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins

916d645

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Feb 8, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 8, 2023

disable alpaka/rocm if rocm not available

91e24fe

smuzaffar mentioned this pull request Feb 8, 2023

Implement HIP/ROCm build rules and test packages cms-sw/cmssw#40627

Closed

cmsbuild added tests-approved and removed tests-started labels Feb 8, 2023

typo: remove alpaka/rocm backend if rocm is not available

319f8ab

cmsbuild added tests-started and removed tests-approved labels Feb 8, 2023

cmsbuild added the requires-external label Feb 8, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 8, 2023

smuzaffar closed this Feb 8, 2023

smuzaffar deleted the smuzaffar-patch-19 branch February 8, 2023 20:21

[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins #8298

[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins #8298

Uh oh!

Conversation

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Build

Uh oh!

cmsbuild commented Feb 8, 2023

Comparison Summary

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Build

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

smuzaffar commented Feb 8, 2023

Uh oh!

cmsbuild commented Feb 8, 2023

Clang Build

Uh oh!

cmsbuild commented Feb 8, 2023

Unit Tests

Uh oh!

cmsbuild commented Feb 9, 2023

Comparison Summary

Uh oh!

cmsbuild commented Feb 9, 2023

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

smuzaffar commented Feb 8, 2023 •

edited

Loading