Skip to content

Conversation

@smuzaffar
Copy link
Contributor

See cms-sw/cmssw#39710
Some times we need to keep the headers in the release to properly print the error and suggest a proper solution to developers. With this new build rule now one should be able to add <flags IGNORE_HEADER_CHECK="file1 file2"/> (where file1 and file2 are relative file path inder package's interface directory) to instruct scram to not run header consistency checks for these files.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Jan 10, 2023

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-096360/29903/summary.html
COMMIT: 9819a2a
CMSSW: CMSSW_13_0_X_2023-01-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8242/29903/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 157
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555359
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit bd6908d into IB/CMSSW_13_0_X/master Jan 11, 2023
@smuzaffar smuzaffar deleted the smuzaffar-patch-4 branch January 11, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants