Skip to content

Conversation

@smuzaffar
Copy link
Contributor

Backport of #8201
llvm 14 has been integrated for CLANG IBs and unit tests which were failing during PR tests worked in IB.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2022

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2022

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/29365/summary.html
COMMIT: 3db7206
CMSSW: CMSSW_13_0_X_2022-11-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8213/29365/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-csc_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
and more ...

RelVals

  • 5.15.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
  • 135.4135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
  • 4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 6 sec (ended on Thu Dec  1 04:51:37 2022) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 3 sec (ended on Thu Dec  1 04:51:39 2022) - exit: 256
[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 3 sec (ended on Thu Dec  1 04:51:44 2022) - exit: 256
Expand to see more addon errors ...

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/29408/summary.html
COMMIT: 3db7206
CMSSW: CMSSW_13_0_X_2022-12-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8213/29408/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 59992 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 116102
  • DQMHistoTests: Total nulls: 340
  • DQMHistoTests: Total successes: 3304695
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1466.9800000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): -162.969 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 11834.0 ): 0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): -162.930 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.229 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.371 KiB SiStrip/MechanicalView
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 15 / 46 workflows

@smuzaffar
Copy link
Contributor Author

ping bot

@smuzaffar
Copy link
Contributor Author

lets wait for all the llvm 14 related code-checks/formats changes to go in cmssw.

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_13_0_X/master to IB/CMSSW_13_1_X/master February 11, 2023 11:53
@cmsbuild
Copy link
Contributor

Pull request #8213 was updated.

@smuzaffar
Copy link
Contributor Author

please test for el8_ppc64le_gcc11

@smuzaffar
Copy link
Contributor Author

please test for el8_aarch64_gcc11

@smuzaffar
Copy link
Contributor Author

please test for el9_amd64_gcc11

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32120/summary.html
COMMIT: c9f1639
CMSSW: CMSSW_13_1_X_2023-04-24-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8213/32120/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32120/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32120/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test Miscellanea had ERRORS
---> test PVall had ERRORS
---> test runtestRecoEgammaPhotonIdentification had ERRORS
and more ...

AddOn Tests

----- Begin Fatal Exception 25-Apr-2023 12:23:25 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root; Network is unreachable�
' (errno=3014, code=400). No additional data servers were found.
      [e] Last URL tried: root://eoscms.cern.ch:1094//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root?tried=&xrdcl.requuid=b6168342-9691-4185-bdcf-575239fe17b8
      [f] Problematic data server: eoscms.cern.ch:1094
      [g] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 25-Apr-2023 12:24:08 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=0767297c-da40-48ef-b9cd-9a02b6bbcd9a
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32119/summary.html
COMMIT: c9f1639
CMSSW: CMSSW_13_1_X_2023-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8213/32119/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test Miscellanea had ERRORS
---> test EoP had ERRORS
---> test PrimaryVertex had ERRORS
---> test DiMuonVertex had ERRORS
and more ...

RelVals

  • 5.15.1_TTbarFS/step1_TTbarFS.log
  • 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
  • 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
Expand to see more relval errors ...

AddOn Tests

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 12 sec (ended on Tue Apr 25 14:00:35 2023) - exit: 256
[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 10 sec (ended on Tue Apr 25 14:00:35 2023) - exit: 256
[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 9 sec (ended on Tue Apr 25 14:00:35 2023) - exit: 256
Expand to see more addon errors ...

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32117/summary.html
COMMIT: c9f1639
CMSSW: CMSSW_13_1_X_2023-04-24-2300/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8213/32117/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32117/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32117/git-merge-result

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32118/summary.html
COMMIT: c9f1639
CMSSW: CMSSW_13_1_X_2023-04-24-2300/el9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8213/32118/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32118/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32118/git-merge-result

Comparison Summary

Summary:

  • You potentially added 34 lines to the logs
  • Reco comparison results: 61113 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460685
  • DQMHistoTests: Total failures: 149935
  • DQMHistoTests: Total nulls: 243
  • DQMHistoTests: Total successes: 3310485
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.556 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -1.465 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.479 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.128 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files

@smuzaffar
Copy link
Contributor Author

please test for el8_aarch64_gcc11

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 26, 2023

@perrotta @rappoccio @makortel , this is ready to go in 13.1.X. Note that few cmssw files will be formated with this update e.g. see [a] where clang-tidy and clang-format were run on full cmssw. We can not apply these changes before we merge llvm14 otherwise existing llvm12 reverts the formating. Any objections on getting this in now?

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/jenkins-test-code-format/CMSSW_13_1_X_2023-04-20-1100/98/

@perrotta
Copy link
Contributor

+orp

  • No objection, provided all needed updates can get implemented in time for next week last open pre-release

@smuzaffar
Copy link
Contributor Author

thanks @perrotta , I will merge this before 11h00 IB and then will open cmssw PRs for clang tidy/format

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32147/summary.html
COMMIT: c9f1639
CMSSW: CMSSW_13_1_X_2023-04-25-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8213/32147/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32147/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea3b55/32147/git-merge-result

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5d88f10 into IB/CMSSW_13_1_X/master Apr 26, 2023
@makortel
Copy link
Contributor

No objections from me either. @smuzaffar Are you planning to make PRs to apply the changes in #8213 (comment)?

@smuzaffar
Copy link
Contributor Author

yes @makortel , once we have the IB with llvm14 available then I will open cmssw PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants