Skip to content

Conversation

@mseidel42
Copy link
Contributor

@mseidel42 mseidel42 commented Nov 24, 2022

Hi, this is a new try for the Rivet update (originally #8109).
I propose to deactivate the Sherpa Rivet interface to disentangle them from each other so that we can update them separately (needed to have the latest Rivet analyses available in CMSSW).
Sherpa+Rivet can still be run through the CMSSW RivetInterface.

I checked that workflow 534.0 runs fine now, no more crashes like those reported in cms-sw/cmssw#39914.

534.0_sherpa_ZtoLL_2j_MEPSatNLO_13TeV_MASTER+sherpa_ZtoLL_2j_MEPSatNLO_13TeV_MASTER+HARVESTGEN Step0-PASSED Step1-PASSED  - time date Thu Nov 24 14:14:32 2022-date Thu Nov 24 14:09:43 2022; exit: 0 0
1 1 tests passed, 0 0 failed

Best,
Markus

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mseidel42 (Markus Seidel) for branch IB/CMSSW_12_6_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 24, 2022

test parameters:

  • workflow = 534.0,536.0
  • enable = threading
  • workflows_threading = 534.0,536.0

@smuzaffar
Copy link
Contributor

please test

@aandvalenzuela aandvalenzuela changed the base branch from IB/CMSSW_12_6_X/master to IB/CMSSW_13_0_X/master November 24, 2022 14:07
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e82ab/29239/summary.html
COMMIT: 611fd56
CMSSW: CMSSW_12_6_X_2022-11-24-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8198/29239/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3419017
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3418989
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 210 log files, 48 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test
lets use 13.0.X/gcc11

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e82ab/29264/summary.html
COMMIT: 611fd56
CMSSW: CMSSW_13_0_X_2022-11-25-1100/el8_amd64_gcc11
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8198/29264/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e82ab/29264/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e82ab/29264/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3419017
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3418992
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 210 log files, 48 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 2e174f0 into cms-sw:IB/CMSSW_13_0_X/master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants