Skip to content

Conversation

@aandvalenzuela
Copy link
Contributor

@aandvalenzuela aandvalenzuela commented Nov 22, 2022

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_6_X/g11_g4_vecgeom.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3174ff/29194/summary.html
COMMIT: bb494a3
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-11-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8195/29194/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #8195 was updated.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3174ff/29206/summary.html
COMMIT: 889a756
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-11-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8195/29206/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3174ff/29206/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3174ff/29206/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 64427 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417167
  • DQMHistoTests: Total failures: 119853
  • DQMHistoTests: Total nulls: 259
  • DQMHistoTests: Total successes: 3297033
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.151999999999995 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.479 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 1.055 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 11834.0 ): 1.898 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 0.694 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.737 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -6.948 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 1.537 KiB SiStrip/MechanicalView
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 15 / 46 workflows

@smuzaffar
Copy link
Contributor

+externals
looks good for G4 with vecgeom IBs

@smuzaffar smuzaffar merged commit 0387454 into cms-sw:IB/CMSSW_12_6_X/g11_g4_vecgeom Nov 24, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/g11_g4_vecgeom IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants