add define to indicate that gcc is nonstandard for llvm, keep .as in addition to .sos #8050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_6_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
Contributor
Author
|
please test |
Contributor
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e82419/27174/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Contributor
|
test parameters:
|
Contributor
|
please test for CMSSW_12_6_CLANG_X |
smuzaffar
reviewed
Aug 30, 2022
| # Avoid dependency on /usr/bin/python, Darwin + Xcode specific | ||
| rm -f %{i}/bin/set-xcode-analyzer | ||
| # Remove all static libs except libomptarget-nvptx.a | ||
| find %{i}/lib64 -name "*.a" -and -not -name "libomptarget-*.a" -delete |
Contributor
There was a problem hiding this comment.
@davidlange6 , note that this adds additional 900MB to distribution
Contributor
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test EcalTPG_updateWeightIdMap_test had ERRORS ---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-beamhlt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS and more ... Comparison SummarySummary:
|
Contributor
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_6_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
smuzaffar
reviewed
Sep 1, 2022
|
|
||
| cmake %{_builddir}/llvm-%{realversion}-%{llvmCommit}/llvm \ | ||
| -G Ninja \ | ||
| -DGCC_INSTALL_PREFIX="${GCC_ROOT}" \ |
Contributor
There was a problem hiding this comment.
@fwyzard , looks like building llvm with GCC_INSTALL_PREFIX fixed the llvm not finding our gcc header issue. After this change now I see that clang++ shows the correct gcc paths
> clang++ -E -x c++ - -v
clang version 14.0.6
Target: x86_64-redhat-linux-gnu
Thread model: posix
InstalledDir: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/bin
Found candidate GCC installation: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0
Selected GCC installation: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0
Candidate multilib: .;@m64
Selected multilib: .;@m64
Found CUDA installation: /cvmfs/cms-ib.cern.ch/nweek-02748/el8_amd64_gcc10/external/cuda/11.5.2-c927b7e765e06433950d8a7eab9eddb4, version 11.5
(in-process)
"/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/bin/clang-14" -cc1 -triple x86_64-redhat-linux-gnu -E -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -v -fcoverage-compilation-dir=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_CLANG_X_2022-08-31-2300 -resource-dir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6 -internal-isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0 -internal-isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0/x86_64-redhat-linux-gnu -internal-isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0/backward -internal-isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6/include -internal-isystem /usr/local/include -internal-isystem /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../x86_64-redhat-linux-gnu/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -fdebug-compilation-dir=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_CLANG_X_2022-08-31-2300 -ferror-limit 19 -fgnuc-version=4.2.1 -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o - -x c++ -
clang -cc1 version 14.0.6 based upon LLVM 14.0.6 default target x86_64-redhat-linux-gnu
ignoring nonexistent directory "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../x86_64-redhat-linux-gnu/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0/x86_64-redhat-linux-gnu
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../include/c++/10.3.0/backward
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6/include
/usr/local/include
/usr/include
End of search list.
Contributor
There was a problem hiding this comment.
I still need to see if it works properly when it is installed on cvmfs
Contributor
Author
|
@fwyzard , looks like building llvm with GCC_INSTALL_PREFIX fixed the llvm not finding our gcc header issue. After this change now I see that clang++ shows the correct gcc paths
Yes, that is indeed what this flag fixes...
|
Contributor
|
humm, not really. @davidlange6 it works in the build area ( where gcc install path and GCC_INSTALL_PREFIX are same) but once things are installed on cvmfs then clang does not find our gcc ( specially in llvm 14) |
Contributor
Author
|
Eg, it doesn't work once gcc is relocated.. (this I didn't test). Hum
… On Sep 1, 2022, at 3:01 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
humm, not really. @davidlange6 it works in the build area ( where gcc install path and GCC_INSTALL_PREFIX are same) but once things are installed on cvmfs then clang does not find our gcc ( specially in llvm 14)
Singularity> which clang++
/cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/bin/clang++
Singularity> which gcc
/cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/gcc
Singularity> echo '' | clang++ -E -x c++ - -v
clang version 14.0.6
Target: x86_64-redhat-linux-gnu
Thread model: posix
InstalledDir: /cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/bin
Found CUDA installation: /cvmfs/cms-ib.cern.ch/nweek-02748/el8_amd64_gcc10/external/cuda/11.5.2-c927b7e765e06433950d8a7eab9eddb4, version 11.5
(in-process)
"/cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/bin/clang-14" -cc1 -triple x86_64-redhat-linux-gnu -E -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -v -fcoverage-compilation-dir=/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/27252/CMSSW_12_6_CLANG_X_2022-08-31-2300 -resource-dir /cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6 -internal-isystem /cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6/include -internal-isystem /usr/local/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -fdebug-compilation-dir=/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7729/27252/CMSSW_12_6_CLANG_X_2022-08-31-2300 -ferror-limit 19 -fgnuc-version=4.2.1 -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o - -x c++ -
clang -cc1 version 14.0.6 based upon LLVM 14.0.6 default target x86_64-redhat-linux-gnu
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/cvmfs/cms-ci.cern.ch/week0/PR_334f39cf/el8_amd64_gcc10/external/llvm/14.0.6-7e877bac6aa04ac511ab1c515ec417ab/lib64/clang/14.0.6/include
/usr/local/include
/usr/include
End of search list.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Contributor
|
looks like llvm 13 and above ignore the |
Contributor
|
we can either patch llvm and add back |
Contributor
|
For the external version of llvm/clang coming with HIP, I'm passing |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These proposed changes are to move towards a more standardized llvm build.