Backport tag update for L1Trigger-L1TGlobal from IB/CMSSW_12_4_X/master

[aandvalenzuela]

backport of #7769

[aandvalenzuela]

please test

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_3_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

• Backported from Update tag for L1Trigger-L1TGlobal to V00-02-00 #7769

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0eac8f/23734/summary.html
COMMIT: 8dce49e
CMSSW: CMSSW_12_3_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7770/23734/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

[smuzaffar]

@aandvalenzuela , there is a build error

ERROR: Duplicate data package definitions found in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist/data/cmsswdata.txt for package L1Trigger-L1TGlobal

I think you have forgot to remove the L1Trigger-L1TGlobal=V00-01-00 line?

[smuzaffar]

ah you need to remove https://github.com/cms-sw/cmsdist/pull/7770/files#diff-27429f03ae22541c3e2b9d4a96fc49fd32d75d896a8b0bb48079ec02ec461887L104 too . For each data repo we can only have one entry in cmsswdata.txt file

[cmsbuild]

Pull request #7770 was updated.

[aandvalenzuela]

Done! Sorry, I was confused. Since the section states #Never update any package here. Always move it to default section. I didn't touch it. Should we update the comment as well?

[aandvalenzuela]

please test

[smuzaffar]

@aandvalenzuela , sure go ahead and update the comment. I thought move in "Always move it to default section" was enough :-)

[smuzaffar]

@aandvalenzuela , can you please also update the PR description and include backport of cms-sw/cmsdist#7769 . This will allow cms bot to add the backport label e.g. see #7755 (comment)

[aandvalenzuela]

Description updated! And for the comment, I think you are right, move should be enough jeje

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0eac8f/23743/summary.html
COMMIT: b20e246
CMSSW: CMSSW_12_3_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7770/23743/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697375
• DQMHistoTests: Total failures: 635
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3696717
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: found differences in 6 / 48 workflows

[perrotta]

please test with #37497

[aandvalenzuela]

Hi @perrotta! Please, link the PR to cms-sw/cmssw so that the bot can find the reference to start the tests. Thank you!

[perrotta]

please test with cms-sw/cmssw#37497

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0eac8f/23764/summary.html
COMMIT: b20e246
CMSSW: CMSSW_12_3_X_2022-04-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7770/23764/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @TaeunKwon [Backport of] HCAL: fix on HCAL TP saturation algorithm to synchronize s/w TP algorithm with f/w cmssw#37472

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0eac8f/23764/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0eac8f/23764/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697351
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Tested together with [Backport] New set of files coherent with the new v1_0_0 L1Menu cmssw#37497