Update mkFit to V3.4.0-0

[mmasciov]

Related CMSSW and cms-data PR are coming.

https://github.com/trackreco/mkFit/releases/tag/V3.4.0-0%2Bpr369

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for branch IB/CMSSW_12_1_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

[makortel]

@cmsbuild, please test with cms-sw/cmssw#35652, cms-data/RecoTracker-MkFit#6

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02010d/19598/summary.html
COMMIT: 43e60ab
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7387/19598/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-13-1100/src/RecoTracker/MkFit/plugins/MkFitEventOfHitsProducer.cc:180:28: error: no matching constructor for initialization of 'const mkfit::BeamSpot &'
  eventOfHits->SetBeamSpot({.x = float(bs.x0()),
                           ^~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/mkfit/3.4.0-01e30e4a7e6bc55e2635ddf5138c4682/include/Hit.h:348:3: note: candidate constructor not viable: cannot convert argument of incomplete type 'void' to 'float' for 1st argument
  BeamSpot(float ix, float iy, float iz, float is, float ibx, float iby, float idxdz, float idydz) :
  ^


[makortel]

@cmsbuild, please test with cms-sw/cmssw#35652, cms-data/RecoTracker-MkFit#6

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02010d/19602/summary.html
COMMIT: 43e60ab
CMSSW: CMSSW_12_1_X_2021-10-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7387/19602/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.7

----- Begin Fatal Exception 13-Oct-2021 18:26:58 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MC_AK8PFHT_v16'
   [2] Calling method for module MkFitEventOfHitsProducer/'hltIter0PFlowCkfTrackCandidatesMkFitEventOfHits'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: reco::BeamSpot
Looking for module label: offlineBeamSpot
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

[smuzaffar]

@cmsbuild, please test with cms-sw/cmssw#35652, cms-data/RecoTracker-MkFit#6

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02010d/19620/summary.html
COMMIT: 43e60ab
CMSSW: CMSSW_12_1_X_2021-10-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7387/19620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2796107
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2796085
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals
but it should be merged with cms-sw/cmssw#35652, cms-data/RecoTracker-MkFit#6

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• To be merged together with #35652