[Herwig7] Patch FXFX.h to match thepeg/LesHouches.h by smuzaffar · Pull Request #7261 · cms-sw/cmsdist

smuzaffar · 2021-09-01T13:31:48Z

Fixes: cms-sw/cmssw#34975
This is workaround to fix the issue cms-sw/cmssw#34975 . See cms-sw/cmssw#34975 (comment)

smuzaffar · 2021-09-01T13:31:55Z

please test

cmsbuild · 2021-09-01T13:32:08Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2021-09-01T13:32:23Z

please test workflow 537.0,538.0

smuzaffar · 2021-09-01T13:33:01Z

please test workflow 537.0,538.0 for slc7_amd64_gcc10

smuzaffar · 2021-09-01T13:33:44Z

please test workflow 537.0,538.0 for slc7_amd64_gcc11

cmsbuild · 2021-09-01T20:02:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18208/summary.html
COMMIT: bb6e499
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7261/18208/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18208/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18208/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/537.0_DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+HARVESTGEN
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000376
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-09-01T20:14:52Z

+externals

cmsbuild · 2021-09-01T20:15:13Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-09-01T21:42:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18210/summary.html
COMMIT: bb6e499
CMSSW: CMSSW_12_1_X_2021-08-31-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7261/18210/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18210/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18210/git-merge-result

Found compilation warnings

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/537.0_DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+HARVESTGEN
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN

Summary:

No significant changes to the logs found
Reco comparison results: 12702 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 119233
DQMHistoTests: Total nulls: 26
DQMHistoTests: Total successes: 2881123
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 45.703 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-09-02T01:02:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18209/summary.html
COMMIT: bb6e499
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7261/18209/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18209/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac4cd7/18209/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/537.0_DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+HARVESTGEN
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ac4cd7/538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 50873 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 197773
DQMHistoTests: Total nulls: 11
DQMHistoTests: Total successes: 2802598
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.244 KiB( 38 files compared)
DQMHistoSizes: changed ( 250202.181 ): -0.064 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 12 / 38 workflows

[Herwig7] Patch FXFX.h to match thepeg/LesHouches.h

bb6e499

cmsbuild added externals-pending orp-pending pending-signatures tests-started labels Sep 1, 2021

smuzaffar mentioned this pull request Sep 1, 2021

Relvals 537.0 and 538.0 failing in GCC10 IB cms-sw/cmssw#34975

Closed

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2021

smuzaffar merged commit ae2ec57 into IB/CMSSW_12_1_X/master Sep 1, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Sep 1, 2021

smuzaffar deleted the herwig7-fxfx-fix branch September 7, 2021 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Herwig7] Patch FXFX.h to match thepeg/LesHouches.h#7261

[Herwig7] Patch FXFX.h to match thepeg/LesHouches.h#7261
smuzaffar merged 1 commit intoIB/CMSSW_12_1_X/masterfrom
herwig7-fxfx-fix

smuzaffar commented Sep 1, 2021 •

edited by mrodozov

Loading

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

smuzaffar commented Sep 1, 2021 • edited by mrodozov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Comparison Summary

Uh oh!

smuzaffar commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Uh oh!

cmsbuild commented Sep 1, 2021

Comparison Summary

Uh oh!

cmsbuild commented Sep 2, 2021

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smuzaffar commented Sep 1, 2021 •

edited by mrodozov

Loading