Further cleaning of python2 packages#7010
Further cleaning of python2 packages#7010smuzaffar merged 4 commits intocms-sw:IB/CMSSW_12_0_X/develfrom
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/devel. @cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
|
Pull request #7010 was updated. |
|
Pull request #7010 was updated. |
|
please test |
FYI @kpedro88 |
|
We're not currently setting up the Triton python client library, but those dependencies may be needed for other parts of the installation. I guess we'll see if it breaks in the test. |
|
while test are still running, let get it in DEVEL IB to run full tests |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_MpsWorkFlow had ERRORS ---> test testAlignmentOfflineValidation had ERRORS ---> test TestFWCorePythonFrameworkDriver had ERRORS ---> test import-backports_abc had ERRORS and more ... Comparison SummarySummary:
|
|
@davidlange6 , we need to slow down this migration :-) we need to fix cms-bot scripts to somehow switch python versions based on release. we have started dropping py2 packages which were needed by bot scripts e.g. psutils, yaml, requests. |
|
While checking the test logs, I noticed something else that should probably be fixed for the python3 migration: |
|
The issue has already been reported in an issue (its not a python3 issue just python3 is smart enough to report it)
… On Jun 11, 2021, at 3:49 PM, Kevin Pedro ***@***.***> wrote:
While checking the test logs, I noticed something else that should probably be fixed for the python3 migration:
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:155: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if not path is '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:174: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:263: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if not path is '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:276: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:414: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:530: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:742: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
For DEVEL.
note - this removes the python dependencies of triton-interface-server - the comments suggest the python interface has been removed