Skip to content

Further cleaning of python2 packages#7010

Merged
smuzaffar merged 4 commits intocms-sw:IB/CMSSW_12_0_X/develfrom
davidlange6:dl210610
Jun 10, 2021
Merged

Further cleaning of python2 packages#7010
smuzaffar merged 4 commits intocms-sw:IB/CMSSW_12_0_X/develfrom
davidlange6:dl210610

Conversation

@davidlange6
Copy link
Contributor

For DEVEL.
note - this removes the python dependencies of triton-interface-server - the comments suggest the python interface has been removed

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/devel.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #7010 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7010 was updated.

@smuzaffar
Copy link
Contributor

please test

@makortel
Copy link
Contributor

note - this removes the python dependencies of triton-interface-server - the comments suggest the python interface has been removed

FYI @kpedro88

@kpedro88
Copy link
Contributor

We're not currently setting up the Triton python client library, but those dependencies may be needed for other parts of the installation. I guess we'll see if it breaks in the test.

@smuzaffar
Copy link
Contributor

while test are still running, let get it in DEVEL IB to run full tests

@smuzaffar smuzaffar merged commit 7d8d934 into cms-sw:IB/CMSSW_12_0_X/devel Jun 10, 2021
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed7e67/15875/summary.html
COMMIT: 396ccc1
CMSSW: CMSSW_12_0_DEVEL_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed7e67/15875/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed7e67/15875/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_MpsWorkFlow had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
---> test TestFWCorePythonFrameworkDriver had ERRORS
---> test import-backports_abc had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5161 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2862485
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@davidlange6 , we need to slow down this migration :-) we need to fix cms-bot scripts to somehow switch python versions based on release. we have started dropping py2 packages which were needed by bot scripts e.g. psutils, yaml, requests.

@kpedro88
Copy link
Contributor

While checking the test logs, I noticed something else that should probably be fixed for the python3 migration:

/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:155: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if not path is '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:174: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:263: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if not path is '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:276: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:414: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:530: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if outputModule is not '':
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7010/15875/CMSSW_12_0_DEVEL_X_2021-06-09-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:742: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if outputModule is not '':

@davidlange6
Copy link
Contributor Author

davidlange6 commented Jun 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants