Patch tkonline to bring pure virtual functions

[mrodozov]

In the latest CLANG IBs after LLVM12 was merged we have new warnings
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc900/www/tue/12.0.CLANG-tue-23/CMSSW_12_0_CLANG_X_2021-06-08-2300
which complain about hidden virtual functions, coming from tkonline. this brings this functions to pure virtual again
the clang IB warnings are fixed with this

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[mrodozov]

please test

[smuzaffar]

please test for CMSSW_12_0_CLANG_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15819/summary.html
COMMIT: 367dabe
CMSSW: CMSSW_12_0_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7003/15819/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Update eigen, get omitted commit #6971 @cms-sw: Update eigen, get omitted commit

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15819/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15819/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15824/summary.html
COMMIT: 367dabe
CMSSW: CMSSW_12_0_CLANG_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7003/15824/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Update eigen, get omitted commit #6971 @cms-sw: Update eigen, get omitted commit

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15824/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b967b9/15824/git-merge-result

Found compilation warnings

Comparison Summary

Summary:

• You potentially added 103071 lines to the logs
• Reco comparison results: 19250 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 57522
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2804970
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 37 files compared)
• DQMHistoSizes: changed ( 136.793 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.012 KiB JetMET/SUSYDQM
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 1 / 37 workflows