Upgrade pythia8 to 305 #6948

mkirsano · 2021-05-30T18:52:08Z

No description provided.

cmsbuild · 2021-05-30T18:52:25Z

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mkirsano · 2021-05-30T19:08:07Z

To be tested together with cmssw PR #33898

mrodozov · 2021-05-30T19:11:06Z

please test with cms-sw/cmssw#33898

cmsbuild · 2021-05-30T20:03:27Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15433/summary.html
COMMIT: c91d035
CMSSW: CMSSW_12_0_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6948/15433/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

install-external+evtgen+2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b
* The action "build-cms+cmssw-tool-conf+46.0-5e3c0fa70e51c07a33ff816f947e1c83" was not completed successfully because The following dependencies could not complete:
install-external+evtgen-toolfile+1.0-e786c96826f0fcb2f5a06e331d5d16ae
* The action "build-external+evtgen+2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b" was not completed successfully because Failed to build evtgen. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/evtgen/2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/evtgen/2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b/evtgen-2.0.0/src/EvtGenExternal/EvtPythiaEngine.cpp: In member function 'void EvtPythiaEngine::updateParticleLists()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/evtgen/2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b/evtgen-2.0.0/src/EvtGenExternal/EvtPythiaEngine.cpp:434:65: error: cannot convert 'Pythia8::ParticleDataEntryPtr' {aka 'std::shared_ptr'} to 'Pythia8::ParticleDataEntry*' in initialization
434 |             _genericPythiaGen->particleData.particleDataEntryPtr( PDGCode );
|             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
|                                                                 |
|                                                                 Pythia8::ParticleDataEntryPtr {aka std::shared_ptr}
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/evtgen/2.0.0-9d4772ab54ed74d24e7a6ebec3768e7b/evtgen-2.0.0/src/EvtGenExternal/EvtPythiaEngine.cpp:436:63: error: cannot convert 'Pythia8::ParticleDataEntryPtr' {aka 'std::shared_ptr'} to 'Pythia8::ParticleDataEntry*' in initialization

iarspider · 2021-05-30T20:22:24Z

I have a patch for EvtGen, let me figure out how to apply it...

iarspider · 2021-05-30T21:59:45Z

Please test with #6949

cmsbuild · 2021-05-30T23:04:31Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15439/summary.html
COMMIT: c91d035
CMSSW: CMSSW_12_0_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6948/15439/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update tag for PhysicsTools-PatUtils to V00-03-00 #6938 @cms-sw: Update tag for PhysicsTools-PatUtils to V00-03-00
New dasgoclient version #6945 @vkuznet: New dasgoclient version

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15439/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15439/git-merge-result

Build

I found compilation error when building:

Copying tmp/slc7_amd64_gcc900/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so to productstore area:
Leaving library rule at FastSimulation/ParticleDecay
Entering library rule at src/FastSimulation/ParticleDecay/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc: In constructor 'TestPythiaDecays::TestPythiaDecays(const edm::ParameterSet&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:122:62: error: cannot convert 'Pythia8::ParticleDataEntryPtr' {aka 'std::shared_ptr'} to 'Pythia8::ParticleDataEntry*' in initialization
  122 |     Pythia8::ParticleDataEntry* pd = pdt.particleDataEntryPtr(pid);
      |                                      ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
      |                                                              |
      |                                                              Pythia8::ParticleDataEntryPtr {aka std::shared_ptr}
gmake: *** [tmp/slc7_amd64_gcc900/src/FastSimulation/ParticleDecay/plugins/FastSimulationParticleDecayAuto/TestPythiaDecays.cc.o] Error 1

mrodozov · 2021-05-31T00:02:59Z

please test with #6949, cms-sw/cmssw#33898

cmsbuild · 2021-05-31T00:34:13Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15441/summary.html
COMMIT: c91d035
CMSSW: CMSSW_12_0_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6948/15441/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update tag for PhysicsTools-PatUtils to V00-03-00 #6938 @cms-sw: Update tag for PhysicsTools-PatUtils to V00-03-00
New dasgoclient version #6945 @vkuznet: New dasgoclient version

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15441/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15441/git-merge-result

Build

I found compilation error when building:

Copying tmp/slc7_amd64_gcc900/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so to productstore area:
Leaving library rule at FastSimulation/ParticleDecay
Entering library rule at src/FastSimulation/ParticleDecay/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc: In constructor 'TestPythiaDecays::TestPythiaDecays(const edm::ParameterSet&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:122:62: error: cannot convert 'Pythia8::ParticleDataEntryPtr' {aka 'std::shared_ptr'} to 'Pythia8::ParticleDataEntry*' in initialization
  122 |     Pythia8::ParticleDataEntry* pd = pdt.particleDataEntryPtr(pid);
      |                                      ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
      |                                                              |
      |                                                              Pythia8::ParticleDataEntryPtr {aka std::shared_ptr}
gmake: *** [tmp/slc7_amd64_gcc900/src/FastSimulation/ParticleDecay/plugins/FastSimulationParticleDecayAuto/TestPythiaDecays.cc.o] Error 1

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/EventProducer/src/FamosManager.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/EventProducer/src/FamosProducer.cc
>> Entering Package FastSimulation/ParticleDecay
Entering library rule at src/FastSimulation/ParticleDecay/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-0000/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:122:33: error: no viable conversion from 'Pythia8::ParticleDataEntryPtr' (aka 'shared_ptr') to 'Pythia8::ParticleDataEntry *'
    Pythia8::ParticleDataEntry* pd = pdt.particleDataEntryPtr(pid);
                                ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
gmake: *** [tmp/slc7_amd64_gcc900/src/FastSimulation/ParticleDecay/plugins/FastSimulationParticleDecayAuto/TestPythiaDecays.cc.o] Error 1
Entering library rule at FastSimulation/ParticleDecay

iarspider · 2021-05-31T08:21:20Z

please test with #6949, cms-sw/cmssw#33898, cms-sw/cmssw#33902

cmsbuild · 2021-05-31T14:29:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15448/summary.html
COMMIT: c91d035
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6948/15448/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid cmssw#33847 @srimanob: Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid
Use better interfaces to Geant4 cmssw#33894 @civanch: Use better interfaces to Geant4
Code-cleanup of RPC-DQM cmssw#33854 @jhgoh: Code-cleanup of RPC-DQM

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15448/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37e67e/15448/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 47440 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 360191
DQMHistoTests: Total nulls: 260
DQMHistoTests: Total successes: 2290013
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 29.908 KiB( 36 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.562 KiB RPC/Muon
DQMHistoSizes: changed ( 1000.0,... ): 0.562 KiB RPC/AllHits
DQMHistoSizes: changed ( 10224.0 ): 0.246 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.361 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.352 KiB SiStrip/MechanicalView
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: found differences in 9 / 36 workflows

mrodozov · 2021-05-31T18:08:13Z

47440 differences found in the comparisons
@mkirsano

mkirsano · 2021-06-07T08:44:43Z

After looking attentively at the logs I found a potential problem. Report sent to the authors, thay admitted that it is a problem. Waiting for solution.

mkirsano · 2021-06-09T07:47:26Z

This is to be substituted by the upgrade to 307 in about one week

smuzaffar · 2021-06-10T21:13:37Z

closing this, please open a new PR with updated version (when available).

Upgrade pythia8 to 305

c91d035

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels May 30, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels May 30, 2021

cmsbuild added tests-rejected and removed tests-started labels May 30, 2021

cmsbuild added tests-started tests-rejected and removed tests-rejected tests-started labels May 30, 2021

cmsbuild added tests-started and removed tests-rejected labels May 31, 2021

cmsbuild added tests-rejected and removed tests-started labels May 31, 2021

iarspider mentioned this pull request May 31, 2021

Fix for Pythia8 >= 304 cms-sw/cmssw#33902

Merged

cmsbuild removed the tests-rejected label May 31, 2021

cmsbuild added the tests-started label May 31, 2021

cmsbuild added tests-approved and removed tests-started labels May 31, 2021

smuzaffar closed this Jun 10, 2021

Upgrade pythia8 to 305 #6948

Upgrade pythia8 to 305 #6948

Uh oh!

Conversation

mkirsano commented May 30, 2021

Uh oh!

cmsbuild commented May 30, 2021

Uh oh!

mkirsano commented May 30, 2021

Uh oh!

mrodozov commented May 30, 2021

Uh oh!

cmsbuild commented May 30, 2021

External Build

Uh oh!

iarspider commented May 30, 2021

Uh oh!

iarspider commented May 30, 2021

Uh oh!

cmsbuild commented May 30, 2021

Build

Uh oh!

mrodozov commented May 31, 2021

Uh oh!

cmsbuild commented May 31, 2021

Build

Clang Build

Uh oh!

iarspider commented May 31, 2021

Uh oh!

cmsbuild commented May 31, 2021

Comparison Summary

Uh oh!

mrodozov commented May 31, 2021

Uh oh!

mkirsano commented Jun 7, 2021

Uh oh!

mkirsano commented Jun 9, 2021

Uh oh!

smuzaffar commented Jun 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants