Skip to content

ThePeg: Patch it to avoid space between quotes and suffix is deprecated in c+23 warnings#10328

Merged
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/g14from
thepeg-cpp23-warn
Feb 5, 2026
Merged

ThePeg: Patch it to avoid space between quotes and suffix is deprecated in c+23 warnings#10328
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/g14from
thepeg-cpp23-warn

Conversation

@smuzaffar
Copy link
Contributor

This PR proposes to patch thepeg to avoid warnings like

  include/ThePEG/Config/Unitsystem.h:163:29: warning: space between quotes and suffix is deprecated in C++23 [-Wdeprecated-literal-operator]
   163 | constexpr Length operator "" _mm( long double x ) {
      |                             ^~
      |                             --
  include/ThePEG/Config/Unitsystem.h:163:29: warning: space between quotes and suffix is deprecated in C++23 [-Wdeprecated-literal-operator]
   163 | constexpr Length operator "" _mm( long double x ) {

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/g14.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for el8_amd64_gcc14

@smuzaffar
Copy link
Contributor Author

+externals

good to go in gcc14 , gcc15 and CPP23 IBs where we get these build warnings

@smuzaffar smuzaffar merged commit 3ebfc68 into IB/CMSSW_16_1_X/g14 Feb 5, 2026
7 of 8 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/g14 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb4d30/51139/summary.html
COMMIT: 0a50dec
CMSSW: CMSSW_16_1_X_2026-02-05-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10328/51139/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb4d30/51139/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb4d30/51139/git-merge-result

Comparison Summary

Summary:

  • You potentially added 245 lines to the logs
  • Reco comparison results: 97564 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4029600
  • DQMHistoTests: Total failures: 463132
  • DQMHistoTests: Total nulls: 242
  • DQMHistoTests: Total successes: 3566206
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -5.801 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): 0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0,... ): -0.399 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0000001 ): -0.039 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0010001,... ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0030001 ): 0.027 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0040001 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0060001,... ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2025.0010001 ): 0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 18 / 50 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants