Skip to content

Update LLVM version 21 for 16.1.X#10322

Merged
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
161x-llvm21
Feb 6, 2026
Merged

Update LLVM version 21 for 16.1.X#10322
smuzaffar merged 1 commit intoIB/CMSSW_16_1_X/masterfrom
161x-llvm21

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Feb 5, 2026

backport LLVM 21 from CLANG_X IBs to default 16.1.X.
Note that we already have applied clang-tidy changes using LLVM 21 to cmssw master branch. After integrating this version, we will open new PRs to run clang-format using llvm21. We can not open format changes using llvm21 as old llcm 18 will revert those changes. So we have to integrate this first

backport of #10142

@smuzaffar
Copy link
Contributor Author

please test using full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

backport of #10142

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e530/51128/summary.html
COMMIT: 9099143
CMSSW: CMSSW_16_1_X_2026-02-04-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10322/51128/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e530/51128/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e530/51128/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 165 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4029600
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4029572
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@makortel @cms-sw/orp-l2 , any objections on getting LLVM21 in 16.1.X normal IBs? Note that once we include it than

@mandrenguyen
Copy link

+1
Good for me!

@makortel
Copy link
Contributor

makortel commented Feb 6, 2026

Fine with me (given that we don't enforce clang-format on production release cycles).

@smuzaffar
Copy link
Contributor Author

+externals

merging this for tonight's IB

@smuzaffar smuzaffar merged commit 43c808a into IB/CMSSW_16_1_X/master Feb 6, 2026
8 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2026

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants