Skip to content

Conversation

@artlbv
Copy link
Contributor

@artlbv artlbv commented Jan 27, 2026

Backport of #10304

This updates the L1 ML TOPO version to the latest one available, moving from tagging a commit to the release: https://github.com/cms-hls4ml/TOPO/releases/tag/v5.0.0

See https://its.cern.ch/jira/browse/CMSLITDPG-1504 for details about the inclusion in the L1 Menu.

cc @quinnanm @BenjaminRS @LukasEbeling

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @artlbv for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2026

cms-bot internal usage

@quinnanm
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed72cf/50936/summary.html
COMMIT: e8005e8
CMSSW: CMSSW_16_0_X_2026-01-27-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10305/50936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4149103
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4149048
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

@artlbv
Copy link
Contributor Author

artlbv commented Jan 27, 2026

These results are odd, especially since the master/161X tests did not find any differences.
OTOH this seems to repeat what already happened before when this external was initially added, and might be due to instability of the L1 trigger results in general: #10146 (comment)
(fyi @cerminar as all these are Phase2 tkElectrons)

Found 10 matching events, out of which 1 have different HLT results

      Events    Accepted      Gained        Lost       Other  Trigger
          10           3           -          -1           -  pIsoTkEleEGEle22_12
          10           3           -          -1           -  pPuppiTauTkIsoEle45_22
          10           3           -          -1           -  pSingleIsoTkEle28
          10           3           -          -1           -  pSingleTkEle36
          10           3           -          -1           -  pTkEleIsoPuppiHT_26_190
          10           3           -          -1           -  pTkElePuppiJet_28_40_MinDR
          10           2           -           -          ~1  HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1
Created the following JSON files:
 /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/upload/triggerResults/34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing/HLT.json

@ftenchini
Copy link

Can this be merged?

@cerminar
Copy link

These results are odd, especially since the master/161X tests did not find any differences. OTOH this seems to repeat what already happened before when this external was initially added, and might be due to instability of the L1 trigger results in general: #10146 (comment) (fyi @cerminar as all these are Phase2 tkElectrons)

Found 10 matching events, out of which 1 have different HLT results

      Events    Accepted      Gained        Lost       Other  Trigger
          10           3           -          -1           -  pIsoTkEleEGEle22_12
          10           3           -          -1           -  pPuppiTauTkIsoEle45_22
          10           3           -          -1           -  pSingleIsoTkEle28
          10           3           -          -1           -  pSingleTkEle36
          10           3           -          -1           -  pTkEleIsoPuppiHT_26_190
          10           3           -          -1           -  pTkElePuppiJet_28_40_MinDR
          10           2           -           -          ~1  HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1
Created the following JSON files:
 /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/upload/triggerResults/34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing/HLT.json

Thanks for the heads-up. Let me add @pviscone as new L1T P2 e/g convener.

@BenjaminRS
Copy link
Contributor

I think the trigger paths mentioned all are using tracker tracks? If so it could be due to cms-sw/cmssw#47071 ?

@BenjaminRS
Copy link
Contributor

Also it should be pointed out the only place where there is a change is in Phase2 workflow. So it is likely the cause is (one of) the reproducibility issues in Phase2 that we need to track down and solve; and not from this PR. Therefore I think it is ok to merge this.

@quinnanm
Copy link
Contributor

It should not be due to the namespace issue seen here: PR#10191 because the emulator code was generated with the namespace fix in place

@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit 9c4aacd into cms-sw:IB/CMSSW_16_0_X/master Jan 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants