Skip to content

Conversation

@smuzaffar
Copy link
Contributor

Resolves cms-externals/geant4#97

Updated following packages for special G4 Its
Geant4: 11.3.ref10
G4EMLOW: 8.8
G4INCL: 1.3
G4PARTICLEXS: 4.2

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_16_0_GEANT4_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_0_X/g4.

@akritkbehera, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_16_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49163/summary.html
COMMIT: 74a114e
CMSSW: CMSSW_16_0_GEANT4_X_2025-10-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10163/49163/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49163/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49163/git-merge-result

Failed Build

I found compilation error when building:

>> Compiling  src/SimG4Core/MagneticField/src/LocalFieldManager.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DCMSSW_GIT_HASH='CMSSW_16_0_GEANT4_X_2025-10-29-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_GEANT4_X_2025-10-29-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_GEANT4_X_2025-10-29-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include/Geant4 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/boost/1.80.0-e126551b432681cba02fb967f887943a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/clhep/2.4.7.1-caf57578c24c3884afdedd94a88b58d7/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/expat/2.4.8-90d4121d63d495f95df72519ccbb6e9c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/SimG4Core/MagneticField/src/SimG4CoreMagneticField/LocalFieldManager.cc.d src/SimG4Core/MagneticField/src/LocalFieldManager.cc -o tmp/el8_amd64_gcc13/src/SimG4Core/MagneticField/src/SimG4CoreMagneticField/LocalFieldManager.cc.o
>> Compiling  src/SimG4Core/MagneticField/src/MonopoleEquation.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DCMSSW_GIT_HASH='CMSSW_16_0_GEANT4_X_2025-10-29-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_GEANT4_X_2025-10-29-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_GEANT4_X_2025-10-29-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include/Geant4 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/boost/1.80.0-e126551b432681cba02fb967f887943a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/clhep/2.4.7.1-caf57578c24c3884afdedd94a88b58d7/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/expat/2.4.8-90d4121d63d495f95df72519ccbb6e9c/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/SimG4Core/MagneticField/src/SimG4CoreMagneticField/MonopoleEquation.cc.d src/SimG4Core/MagneticField/src/MonopoleEquation.cc -o tmp/el8_amd64_gcc13/src/SimG4Core/MagneticField/src/SimG4CoreMagneticField/MonopoleEquation.cc.o
In file included from src/SimG4Core/MagneticField/src/FieldStepper.cc:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include/Geant4/G4TClassicalRK4.hh:57:34: error: expected ';' at end of member declaration
   57 |     virtual ~G4TClassicalRK4() = default
      |                                  ^~~~~~~
      |                                         ;
gmake: *** [tmp/el8_amd64_gcc13/src/SimG4Core/MagneticField/src/SimG4CoreMagneticField/FieldStepper.cc.o] Error 1
>> Compiling bigobj src/SimG4Core/MagneticField/src/CMSFieldManager.cc


@smuzaffar
Copy link
Contributor Author

@civanch , looks like a typo at https://github.com/cms-externals/geant4/blob/cms/v11.3.ref10/source/geometry/magneticfield/include/G4TClassicalRK4.hh#L57 causing the following build error in cmssw. I can fix it in out geant4 fork or do you want to fix it upstream first and provide a new tar file?

 geant4/11.3.ref10-1abe9fa8b3f1801bcdca6f59591a4287/include/Geant4/G4TClassicalRK4.hh:57:34: error: expected ';' at end of member declaration
    57 |     virtual ~G4TClassicalRK4() = default

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

Pull request #10163 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_16_0_GEANT4_X

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_16_0_G4VECGEOM_X

@smuzaffar
Copy link
Contributor Author

+externals

good to go in special Geant4 IBs

@smuzaffar smuzaffar merged commit faa4ac1 into IB/CMSSW_16_0_X/g4 Nov 2, 2025
12 of 14 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/g4 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49174/summary.html
COMMIT: 2888592
CMSSW: CMSSW_16_0_GEANT4_X_2025-10-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10163/49174/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49174/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49174/git-merge-result

Comparison Summary

Summary:

  • You potentially added 297 lines to the logs
  • Reco comparison results: 61030 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 529417
  • DQMHistoTests: Total nulls: 343
  • DQMHistoTests: Total successes: 3410173
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.9580000000000004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.427 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -2.524 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): 2.445 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.170 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.181 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.463 KiB SiStrip/MechanicalView
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 15 / 49 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49176/summary.html
COMMIT: 2888592
CMSSW: CMSSW_16_0_G4VECGEOM_X_2025-10-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10163/49176/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49176/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d3a40/49176/git-merge-result

Comparison Summary

Summary:

  • You potentially added 557 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61471 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 529253
  • DQMHistoTests: Total nulls: 342
  • DQMHistoTests: Total successes: 3410338
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7.848999999999999 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -5.866 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): 2.367 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.479 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -4.340 KiB SiStrip/MechanicalView
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 16 / 49 workflows

@smuzaffar smuzaffar deleted the g4-11.3.ref10 branch November 3, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants