Skip to content

Conversation

@fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 31, 2025

No description provided.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 31, 2025

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ebadb/49117/summary.html
COMMIT: ca124af
CMSSW: CMSSW_16_0_X_2025-10-30-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10158/49117/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ebadb/49117/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ebadb/49117/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

@makortel @Dr15Jones , do you want some local tests before we integrate it? If needed I can integrate it in DEVEL IBs first

@Dr15Jones
Copy link

I'm not concerned about a local test before integration as long as it is done after CMSSW_16_0_0_pre2 is out :).

@makortel
Copy link
Contributor

do you want some local tests before we integrate it?

Not really.

If needed I can integrate it in DEVEL IBs first

I'm not sure that is necessary. I am a bit concerned though about the large number of comparison differences

and they seem to be concentrated to a few phase 2 workflows

29634.0 52562
29634.75 14928
29634.911 2751
29696.0 98
29834.999 911

TBB update shouldn't really change physics results...

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 1, 2025

TBB update shouldn't really change physics results...

Indeed, it shouldn't 🤷🏻‍♂️

I'll re-run the tests once pre2 is out.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ebadb/49161/summary.html
COMMIT: ca124af
CMSSW: CMSSW_16_0_X_2025-11-02-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10158/49161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939890
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 50e1ca3 into cms-sw:IB/CMSSW_16_0_X/master Nov 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants