Integrate Acts v44.0.1 (with minimal changes) as an external #10156

fwyzard · 2025-10-28T18:29:55Z

Following the approval of the work by Lorenzo on "Enhancing CMS Passive Material Modeling in Track Reconstruction Using ACTS" (link), add ACTS as an external to CMSSW to simplify further developments.

Enable the plugins for SVG, Json, Root, DD4Hep, Geant4, Covfie, and Detray, and define individual tools for each Acts plugin and external library.

Backport acts-project/acts#4357 to the v44.0.x branch: implement the Gen3 geometry to detray conversion.

Backport acts-project/acts#4757 to the v44.0.x branch: Update namespace for Nlohmann Json v3.11 and later.

Backport acts-project/acts#4758 to the v44.0.x branch: update Traccc to v0.26.0 to be compatible with Acts v44.0.x, with the corresponding external updates:

detary v0.103.0
covfie v0.15.2
vecmem v1.21.0
algebra plugins v0.28.0

Target the CUDA and ROCm architectures supported by CMSSW.

cmsbuild · 2025-10-28T18:30:20Z

A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-10-28T18:30:21Z

cms-bot internal usage

fwyzard · 2025-10-28T18:34:04Z

Following the (pre)approval of of the DPS note on "Enhancing CMS Passive Material Modeling in
Track Reconstruction Using ACTS" ¹·²·³, this makes Acts and the Detray geometry available in CMSSW, for further developments and studies.

¹ https://indico.cern.ch/event/1567991/contributions/6756688/attachments/3159465/5612854/DPS_note_CTD.pdf
² https://indico.cern.ch/event/1567991/contributions/6756688/attachments/3159465/5612863/ACTSinCMSSW_DPG_POG.pdf
³ https://indico.cern.ch/event/1567991/contributions/6756688/attachments/3159465/5612855/PosterCTD_Draft.pdf

fwyzard · 2025-10-28T18:36:15Z

Currently there are no tests or modules that use Acts in CMSSW.

The tests are available in a separate branch (https://github.com/fwyzard/cmssw/tree/acts_unit_tests): all of the build, and most of them pass. However, I'm not suggesting to add them to CMSSW for the time being, unless there is a request to do so.

Dedicated modules are being developed, and would benefit from having the external available.

cmsbuild · 2025-10-28T18:36:54Z

Pull request #10156 was updated.

smuzaffar · 2025-10-29T11:30:32Z

acts.spec

+  -DCMAKE_CXX_STANDARD=%{cms_cxx_standard} \
+  -DCMAKE_INSTALL_PREFIX="%{i}" \
+  -DCMAKE_BUILD_TYPE=Release \
+  -DCMAKE_PREFIX_PATH="${PYTHON3_ROOT};${XERCES_C_ROOT};${DD4HEP_ROOT};${JSON_ROOT};${EXPAT_ROOT};${ZLIB_ROOT};${GEANT4_ROOT};${BOOST_ROOT};${EIGEN_ROOT};${ROOT_ROOT}%{!?without_cuda:;${CUDA_ROOT}}%{!?without_rocm:;${ROCM_ROOT}}" \


Suggested change

-DCMAKE_PREFIX_PATH="${PYTHON3_ROOT};${XERCES_C_ROOT};${DD4HEP_ROOT};${JSON_ROOT};${EXPAT_ROOT};${ZLIB_ROOT};${GEANT4_ROOT};${BOOST_ROOT};${EIGEN_ROOT};${ROOT_ROOT}%{!?without_cuda:;${CUDA_ROOT}}%{!?without_rocm:;${ROCM_ROOT}}" \

-DCMAKE_PREFIX_PATH="%{cmake_prefix_path}" \

cmake_prefix_path macro expands to the install path of all the dependencies

oh, thanks !

smuzaffar · 2025-10-29T11:32:11Z

@fwyzard , please add acts dependency in cmssw-tools.spec too otherwise it will not be built

fwyzard · 2025-10-29T11:34:07Z

@fwyzard , please add acts dependency in cmssw-tools.spec too otherwise it will not be built

right... will do

cmsbuild · 2025-10-29T13:50:07Z

Pull request #10156 was updated.

fwyzard · 2025-10-29T13:50:13Z

Both comments have been addressed.

fwyzard · 2025-10-29T13:50:31Z

please test

cmsbuild · 2025-10-29T16:23:29Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/48891/summary.html
COMMIT: 0274100
CMSSW: CMSSW_16_0_X_2025-10-28-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10156/48891/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw configtag V09-08-12 which contains fix for cuda source file dependency #10154
@cms-sw Reduce built time for tool-conf by process tools files in parallel #10155

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/48891/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/48891/git-merge-result

Comparison Summary

Summary:

You potentially removed 54 lines from the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 15945
DQMHistoTests: Total nulls: 22
DQMHistoTests: Total successes: 3923966
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: found differences in 4 / 49 workflows

smuzaffar · 2025-10-30T08:48:47Z

@fwyzard , can you please relocate bin/this_acts_withdeps.sh and bin/this_acts.sh files https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/48891/external_checks/relocate/acts.txt . Just adding the following in %post sectiomn should work

%{relocateConfig}bin/this_acts_withdeps.sh
%{relocateConfig}bin/bin/this_acts.sh

fwyzard · 2025-10-30T09:03:27Z

Sure, I'll look into that.

I'm wondering if we should keep those files or not ?
If we keep them, should we add ACTS bin directory to the PATH ?

cmsbuild · 2025-10-30T09:56:26Z

Pull request #10156 was updated.

cmsbuild · 2025-11-02T18:42:22Z

Pull request #10156 was updated.

fwyzard · 2025-11-02T18:44:54Z

please test for el9_amd64_gcc13

cmsbuild · 2025-11-03T02:16:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/49184/summary.html
COMMIT: bc3b548
CMSSW: CMSSW_16_0_X_2025-11-02-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10156/49184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 192 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 68343 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 520586
DQMHistoTests: Total nulls: 330
DQMHistoTests: Total successes: 3419017
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -10.084 KiB( 50 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -7.492 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 3.184 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 2024.0040001 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -5.600 KiB SiStrip/MechanicalView
Checked 218 log files, 188 edm output root files, 51 DQM output files

fwyzard · 2025-11-03T05:10:50Z

please test

cmsbuild · 2025-11-03T08:32:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb548/49187/summary.html
COMMIT: bc3b548
CMSSW: CMSSW_16_0_X_2025-11-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10156/49187/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 77
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3939856
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

iarspider · 2025-11-03T18:12:01Z

+externals

I guess the

CMake Warning:
  Manually-specified variables were not used by the project:

    AMDGPU_TARGETS

will be fixed once AMD/ROCm is working, right?

cmsbuild · 2025-11-03T18:12:24Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2025-11-03T18:17:48Z

Thanks for pointing that out.

Yes, I think the warning is there because we are not building the ROCm backend yet.
Still, I'll see if I can conditionally disable that flag.

fwyzard · 2025-11-03T18:26:16Z

@iarspider #10166 should fix the warning message.

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Oct 28, 2025

fwyzard changed the title ~~Integrate ACTS v44.0.1 (with minimal changes) as en external for CMSSW~~ Integrate ACTS v44.0.1 (with minimal changes) as en external Oct 28, 2025

fwyzard changed the title ~~Integrate ACTS v44.0.1 (with minimal changes) as en external~~ Integrate ACTS v44.0.1 (with minimal changes) as an external Oct 28, 2025

fwyzard force-pushed the IB/CMSSW_16_0_X/master_acts_for_cms branch from 344596d to 01ca53d Compare October 28, 2025 18:36

smuzaffar reviewed Oct 29, 2025

View reviewed changes

fwyzard force-pushed the IB/CMSSW_16_0_X/master_acts_for_cms branch from 01ca53d to 0274100 Compare October 29, 2025 13:49

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2025

fwyzard force-pushed the IB/CMSSW_16_0_X/master_acts_for_cms branch from 0274100 to 8ff97f8 Compare October 30, 2025 09:56

cmsbuild added tests-pending and removed tests-approved labels Oct 30, 2025

cmsbuild added the tests-pending label Nov 2, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 2, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 3, 2025

cmsbuild added tests-started and removed tests-approved labels Nov 3, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 3, 2025

iarspider merged commit 37dd679 into cms-sw:IB/CMSSW_16_0_X/master Nov 3, 2025
14 checks passed

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Nov 3, 2025

fwyzard changed the title ~~Integrate ACTS v44.0.1 (with minimal changes) as an external~~ Integrate Acts v44.0.1 (with minimal changes) as an external Nov 3, 2025

	-DCMAKE_PREFIX_PATH="${PYTHON3_ROOT};${XERCES_C_ROOT};${DD4HEP_ROOT};${JSON_ROOT};${EXPAT_ROOT};${ZLIB_ROOT};${GEANT4_ROOT};${BOOST_ROOT};${EIGEN_ROOT};${ROOT_ROOT}%{!?without_cuda:;${CUDA_ROOT}}%{!?without_rocm:;${ROCM_ROOT}}" \
	-DCMAKE_PREFIX_PATH="%{cmake_prefix_path}" \

Integrate Acts v44.0.1 (with minimal changes) as an external #10156

Integrate Acts v44.0.1 (with minimal changes) as an external #10156

Uh oh!

Conversation

fwyzard commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 28, 2025

Uh oh!

cmsbuild commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Oct 28, 2025

Uh oh!

fwyzard commented Oct 28, 2025

Uh oh!

cmsbuild commented Oct 28, 2025

Uh oh!

smuzaffar Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

smuzaffar commented Oct 29, 2025

Uh oh!

fwyzard commented Oct 29, 2025

Uh oh!

cmsbuild commented Oct 29, 2025

Uh oh!

fwyzard commented Oct 29, 2025

Uh oh!

fwyzard commented Oct 29, 2025

Uh oh!

cmsbuild commented Oct 29, 2025

Comparison Summary

Uh oh!

smuzaffar commented Oct 30, 2025

Uh oh!

fwyzard commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

cmsbuild commented Nov 2, 2025

Uh oh!

fwyzard commented Nov 2, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Comparison Summary

Uh oh!

fwyzard commented Nov 3, 2025

Uh oh!

cmsbuild commented Nov 3, 2025

Comparison Summary

Uh oh!

iarspider commented Nov 3, 2025

Uh oh!

Uh oh!

cmsbuild commented Nov 3, 2025

Uh oh!

fwyzard commented Nov 3, 2025

Uh oh!

fwyzard commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fwyzard commented Oct 28, 2025 •

edited

Loading

cmsbuild commented Oct 28, 2025 •

edited

Loading