Update Catch2 from v2 to v3#10119
Conversation
|
cms-bot internal usage |
|
please test with cms-sw/cmssw#49121 for CMSSW_16_0_X |
|
@akritkbehera , there is no need to rename the package, just use the catch2.apec (all packages for scram are anyway lower case). Revert the rename change and force pushed it |
|
@smuzaffar do we need to bump tool file version? |
|
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Package SimCalorimetry/EcalZeroSuppressionAlgos built Copying tmp/el8_amd64_gcc13/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/libtestRocmSoALayoutAndView_t_rocm.a to productstore area: Copying tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaCopyBufferToDeviceROCmAsync/libalpakaCopyBufferToDeviceROCmAsync_rocm.a to productstore area: cp: cannot stat 'tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaCopyBufferToDeviceROCmAsync/libalpakaCopyBufferToDeviceROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaCopyBufferToDeviceROCmAsync/libalpakaCopyBufferToDeviceROCmAsync_rocm.a gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaCopyBufferToDeviceROCmAsync/libalpakaCopyBufferToDeviceROCmAsync_rocm.a] Error 1 Copying tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaMoveToDeviceAsyncROCmAsync/libalpakaMoveToDeviceAsyncROCmAsync_rocm.a to productstore area: cp: cannot stat 'tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaMoveToDeviceAsyncROCmAsync/libalpakaMoveToDeviceAsyncROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaMoveToDeviceAsyncROCmAsync/libalpakaMoveToDeviceAsyncROCmAsync_rocm.a gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaMoveToDeviceAsyncROCmAsync/libalpakaMoveToDeviceAsyncROCmAsync_rocm.a] Error 1 Copying tmp/el8_amd64_gcc13/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/libalpakaTestAtomicPairCounterROCmAsync_rocm.a to productstore area: Clang BuildI found compilation error while trying to compile with clang. Command used: >> Entering Package TrackingTools/TrajectoryParametrization >> Entering Package TrackingTools/TrajectoryState >> Entering Package TrackingTools/TransientTrack >> Entering Package TrackingTools/TransientTrackingRecHit >> Compile sequence completed for CMSSW CMSSW_16_0_X_2025-10-10-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 Command exited with non-zero status 1 Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes" User time (seconds): 45249.95 System time (seconds): 5527.04 Percent of CPU this job got: 1428% |
b694055 to
c0a04e0
Compare
|
Pull request #10119 was updated. |
|
please test with cms-sw/cmssw#49121 for CMSSW_16_0_X |
The source archive unpacks to 'Catch2-%{realversion}', so I’m using that name here instead of %{n}. |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00a688/48608/summary.html |
c0a04e0 to
3e9552a
Compare
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00a688/48616/summary.html Comparison SummarySummary:
|
|
@Dr15Jones , do we care if catch2 libs are archive or shared? |
|
A new Pull Request was created by @akritkbehera for branch IB/CMSSW_16_0_X/master. @akritkbehera, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
Given catch2 is only meant to generate executables and not libraries, I don't think it matters. |
|
please test with cms-sw/cmssw#49121 for CMSSW_16_0_X |
|
Pull request #10119 was updated. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00a688/48633/summary.html Comparison SummarySummary:
|
|
+externals @cms-orp, this should be merged along with cms-sw/cmssw#49121 |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
REMINDER @ftenchini, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmssw#49121, please check if they should be merged together |
|
+1 |
This update bumps Catch2 from version v2 to v3,
This PR includes