Skip to content

Move CLUE to V_1_1_1.#10114

Merged
iarspider merged 3 commits intocms-sw:IB/CMSSW_16_0_X/masterfrom
rovere:updateClue_V110
Oct 8, 2025
Merged

Move CLUE to V_1_1_1.#10114
iarspider merged 3 commits intocms-sw:IB/CMSSW_16_0_X/masterfrom
rovere:updateClue_V110

Conversation

@rovere
Copy link
Contributor

@rovere rovere commented Oct 7, 2025

  • Include the patch related to clamp
  • Improve performance of makeClustersCMSSW

- Include the patch related to clamp
- Improve performance of makeClustersCMSSW
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

A new Pull Request was created by @rovere for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

cms-bot internal usage

@rovere
Copy link
Contributor Author

rovere commented Oct 7, 2025

@mmusich @felicepantaleo @waredjeb

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a2259/48508/summary.html
COMMIT: 2b5a158
CMSSW: CMSSW_16_0_X_2025-10-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10114/48508/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
Requested to quit.
Requested to quit.
Requested to quit.
* The action "build-external+clue+1.1.0-10d0d8392b336b2f01d44adb9bfc5ef3" was not completed successfully because Failed to build clue. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc13/external/clue/1.1.0-10d0d8392b336b2f01d44adb9bfc5ef3/log. Final lines of the log file:
error: No patch number 0

* The action "install-external+clue+1.1.0-10d0d8392b336b2f01d44adb9bfc5ef3" was not completed successfully because The following dependencies could not complete:
build-external+clue+1.1.0-10d0d8392b336b2f01d44adb9bfc5ef3
* The action "build-cms+cmssw-tools+3.0-3b5c37f7910ba7f12d178a8c3bd29cf8" was not completed successfully because The following dependencies could not complete:
install-external+clue+1.1.0-10d0d8392b336b2f01d44adb9bfc5ef3


@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

Pull request #10114 was updated.

@rovere
Copy link
Contributor Author

rovere commented Oct 7, 2025

thanks @iarspider ! I deleted the patch file but forgot to remove also the patch command....

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a2259/48509/summary.html
COMMIT: d25e154
CMSSW: CMSSW_16_0_X_2025-10-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10114/48509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@iarspider
Copy link
Contributor

+externals
all good from externals point of view

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor

fwyzard commented Oct 7, 2025

does this run anything on GPUs ?

@mmusich
Copy link
Contributor

mmusich commented Oct 7, 2025

does this run anything on GPUs ?

it can run also on GPU - yes, if that's the question.

@fwyzard
Copy link
Contributor

fwyzard commented Oct 7, 2025

Should we run the GPU tests as well, then ?

@mmusich
Copy link
Contributor

mmusich commented Oct 7, 2025

Should we run the GPU tests as well, then ?

we did run them at cms-sw/cmssw#49078 (there's a failure).

@fwyzard
Copy link
Contributor

fwyzard commented Oct 7, 2025

Ah, OK.
(I get the notifications for all cmsdist packages, but not for all cmssw packages :-D)

Extend the Tile initialization to also cover the search extensions.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

Pull request #10114 was updated.

@rovere
Copy link
Contributor Author

rovere commented Oct 8, 2025

ok @iarspider I think I'm done. It tests are ok also in CMSSW (we have a crash), this PR is good to go!

@iarspider
Copy link
Contributor

+externals

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2025

@cmsbuild, please test

@iarspider iarspider merged commit 510ebb1 into cms-sw:IB/CMSSW_16_0_X/master Oct 8, 2025
2 of 3 checks passed
@fwyzard
Copy link
Contributor

fwyzard commented Oct 8, 2025

I'm confused by

tests are ok also in CMSSW (we have a crash)

...so, tests are not ok ?

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2025

...so, tests are not ok ?

I think this was merged a bit hastily, but I tested yesterday this PR (as of today using CLUE V 1.1.1 and not V 1.1.0) + cms-sw/cmssw#49078 on AMD_MI300X via pod to the NGT farm and didn't observe crashes.

@rovere rovere changed the title Move CLUE to V_1_1_0. Move CLUE to V_1_1_1. Oct 8, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a2259/48535/summary.html
COMMIT: 7e1240c
CMSSW: CMSSW_16_0_X_2025-10-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10114/48535/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a2259/48535/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a2259/48535/git-merge-result

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2025

DQMHistoTests: Total failures: 454

differences are spurious, due to cms-sw/cmssw#49073 and cms-sw/cmssw#47071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants