Fail the run-pr-external_checks if it can not find cmssw-tool-conf

[smuzaffar]

run-pr-external_checks.sh is silently failing since we move to cmssw-tools instead of cmssw-tool-conf. This change makes sure that external checks are marked failed if they can not find cmssw-tool-conf.

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cmsdist#10074

with current change the external checks should fail as they will not be able to find cmssw-tools

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48106/summary.html
COMMIT: 9c04bc3
CMSSW: CMSSW_16_0_X_2025-09-14-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2567/48106/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @kpedro88 expose additional libraries needed for celeritas geant4 interface compilation cmsdist#10069

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48106/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48106/git-merge-result

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4113751
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4113728
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #2567 was updated.

[smuzaffar]

please test with cms-sw/cmsdist#10072

[smuzaffar]

please test with cms-sw/cmsdist#10072

[cmsbuild]

Pull request #2567 was updated.

[smuzaffar]

+externals

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48117/summary.html now properly find the cmssw tools and report for any relocation issues

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10072

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48121/summary.html
COMMIT: 7e5fcd4
CMSSW: CMSSW_16_0_X_2025-09-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2567/48121/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_DavixReadV_http had ERRORS
---> test test_DavixRead_http had ERRORS

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4113751
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4113708
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found