Skip to content

New bot command: please build #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iarspider wants to merge 8 commits into from
Closed

New bot command: please build #2525

iarspider wants to merge 8 commits into from

Conversation

@iarspider
Copy link
Contributor

@iarspider iarspider commented Jul 3, 2025

Redo of #2513

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2025

Pull request #2525 was updated.

@iarspider iarspider mentioned this pull request Jul 9, 2025
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

@iarspider
Copy link
Contributor Author

iarspider commented Jul 9, 2025

@cmsbuild please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

@iarspider iarspider marked this pull request as ready for review July 9, 2025 13:25
@iarspider iarspider marked this pull request as draft July 9, 2025 15:19
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #2525 was updated.

9 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2025

Pull request #2525 was updated.

@iarspider iarspider marked this pull request as ready for review July 12, 2025 09:32
smuzaffar
smuzaffar reviewed Jul 14, 2025
View reviewed changes
smuzaffar
smuzaffar reviewed Jul 14, 2025
View reviewed changes
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2025

A new Pull Request was created by @iarspider for branch master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Jul 15, 2025

@iarspider , do you understand why after cms-sw/cmssw#48061 (comment) ( i.e. please build ) the test label was set to tests-pending ?

smuzaffar
smuzaffar reviewed Jul 15, 2025
View reviewed changes
process_pr.py
trigger_test = True
signatures["tests"] = "started"
if not build_only:
signatures["tests"] = "started"
Copy link
Contributor

@smuzaffar smuzaffar Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , may be this change is not needed? we override the test labels for build_only any way .... right?

Copy link
Contributor Author

@iarspider iarspider Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

smuzaffar
smuzaffar reviewed Jul 15, 2025
View reviewed changes
process_pr.py
and bot_status.target_url == turl
and signatures["tests"] == "pending"
and (" requested by " in bot_status.description)
and not build_only
Copy link
Contributor

@smuzaffar smuzaffar Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , may be this is also not needed?

Copy link
Contributor Author

@iarspider iarspider Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2025

Pull request #2525 was updated.

smuzaffar
smuzaffar reviewed Jul 17, 2025
View reviewed changes
process_pr.py
test_comment = comment
build_only = v5
signatures["tests"] = "pending"

Copy link
Contributor

@smuzaffar smuzaffar Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarspider , I do not think this is what we discussed :-)

Copy link
Contributor Author

@iarspider iarspider Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? Then I misunderstood your suggestion.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2025

Pull request #2525 was updated.

@iarspider iarspider mentioned this pull request Jul 17, 2025
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2025

Pull request #2525 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2025

Pull request #2525 was updated.

@smuzaffar smuzaffar mentioned this pull request Jul 22, 2025
Merged
@iarspider iarspider closed this Jul 22, 2025
@iarspider iarspider deleted the build-only-v2 branch August 28, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees

No one assigned

Labels

externals-pending orp-pending pending-signatures tests-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iarspider @cmsbuild @smuzaffar