Make static analyzer errors more visible

[iarspider]

No description provided.

[cmsbuild]

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cmssw#48035

[smuzaffar]

@iarspider , can you please open a cmssw draft PR to test this? My try of cms-sw/cmssw#48035 did not work

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faf788/45967/summary.html
COMMIT: 3dd76a2
CMSSW: CMSSW_15_1_X_2025-05-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2495/45967/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @kyungminparkdrums [15_1_X] Fix ECAL DQM crash from ME formatter when there is no luminosity block cmssw#48027
• @mmusich reduce memory allocations per event in string manipulation in SiStripMonitorTrack::analyze() cmssw#48026
• @mmusich add HLT trimmed pixel vertices monitoring in online DQM cmssw#48025
• @Parsifal-2045 Fix HLT MTV to work with singleIterPatatrack and LST procModifiers cmssw#48031
• @iarspider Add ability to output JetTagClass to std::ostream cmssw#48020
• @SegmentLinking Migrate LST inputs to SoA collections cmssw#47793
• @bsunanda Phase2-hgx363AB Correct the dd4hep version for V19 geometry definition of HGCal cmssw#48029

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faf788/45967/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faf788/45967/git-merge-result

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4037687
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4037656
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@iarspider , can you please open a cmssw draft PR to test this? My try of cms-sw/cmssw#48035 did not work

@iarspider ??

[iarspider]

I am looking into it - I need to figure out how to make clang analyzer report an error (all of it's diagnostics are emitted as warnings, not errors).

[iarspider]

please test with cms-sw/cmssw#48065

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-faf788/46127/summary.html
COMMIT: 3dd76a2
CMSSW: CMSSW_15_1_X_2025-05-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2495/46127/install.sh to create a dev area with all the needed externals and cmssw changes.

• Static analyzer reported errors, please check

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4038193
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4038153
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[iarspider]

@iarspider , can you please open a cmssw draft PR to test this? My try of cms-sw/cmssw#48035 did not work

see cms-sw/cmssw#48065 + test results in #2495 (comment)

[smuzaffar]

thanks @iarspider

Looks like we can use $${\color{red} some text }$$ ( $${\color{red} sometext }$$ ) to have colored text . Can you please use it for such errors connects? Also for the text we add for failed tests Failed Tests: RelVals

[smuzaffar]

+externals

This could go in, @iarspider open a new PR for highlighting error message in different color

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#48065