Skip to content

PR Testing: check for warnings also in files not directly touched by PR#2379

Merged
smuzaffar merged 5 commits intomasterfrom
indirect-changed-files-v2
Dec 2, 2024
Merged

PR Testing: check for warnings also in files not directly touched by PR#2379
smuzaffar merged 5 commits intomasterfrom
indirect-changed-files-v2

Conversation

@iarspider
Copy link
Contributor

No description provided.

@iarspider iarspider changed the title PR Testing: check for warnings also in files not directly touched by PR [WIP] PR Testing: check for warnings also in files not directly touched by PR Nov 21, 2024
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2379 was updated.

@iarspider iarspider marked this pull request as ready for review November 25, 2024 14:21
@iarspider iarspider changed the title [WIP] PR Testing: check for warnings also in files not directly touched by PR PR Testing: check for warnings also in files not directly touched by PR Nov 25, 2024
@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4abd54/43110/summary.html
COMMIT: 9fbc008
CMSSW: CMSSW_15_0_X_2024-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2379/43110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 1897
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3481805
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@cmsbuild
Copy link
Contributor

Pull request #2379 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4abd54/43118/summary.html
COMMIT: b59dc66
CMSSW: CMSSW_15_0_X_2024-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2379/43118/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #2379 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4abd54/43149/summary.html
COMMIT: 6e374bb
CMSSW: CMSSW_15_0_X_2024-11-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2379/43149/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 489
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484173
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@cmsbuild
Copy link
Contributor

Pull request #2379 was updated.

@smuzaffar
Copy link
Contributor

please test

test look good now cmssw pr cms-sw/cmssw#46579 (comment)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4abd54/43159/summary.html
COMMIT: 0e93fb9
CMSSW: CMSSW_15_0_X_2024-11-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2379/43159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 1870
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3482792
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@smuzaffar smuzaffar merged commit 4b6fb53 into master Dec 2, 2024
@smuzaffar smuzaffar deleted the indirect-changed-files-v2 branch December 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants