Skip to content

Conversation

@aandvalenzuela
Copy link
Contributor

Changes proposed in #2319 needed rebasing

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2378 was updated.

@aandvalenzuela
Copy link
Contributor Author

aandvalenzuela commented Nov 18, 2024

This changes are only supposed to be merged once we agree on a Python formatting tool since it will process all touched *.py files in a PR. Discussion for Ruff formatting can be found at cms-sw/cmssw#45706.

After @Benedikttk's summer project, the conclusion was not to use Ruff as a formatting tool due to the lack of customization options. Google's YAPF was proposed as the next tool to be evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants