Skip to content

PR Testing: check for warnings also in files not directly touched by PR #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smuzaffar merged 5 commits into from
Nov 14, 2024
Merged

PR Testing: check for warnings also in files not directly touched by PR #2361

smuzaffar merged 5 commits into from
Nov 14, 2024

Conversation

@iarspider
Copy link
Contributor

@iarspider iarspider commented Oct 18, 2024

As suggested here: cms-sw/cmssw#46388 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024 •
edited
Loading

cms-bot internal usage

@iarspider iarspider force-pushed the indirect-changed-files branch from a0573bd to c52b5dd Compare October 21, 2024 13:30
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2024

Pull request #2361 was updated.

@iarspider iarspider mentioned this pull request Oct 22, 2024
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2024

Pull request #2361 was updated.

2 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2024

Pull request #2361 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2024

Pull request #2361 was updated.

@iarspider iarspider force-pushed the indirect-changed-files branch from 5bbca61 to 405d178 Compare October 28, 2024 10:47
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2024

Pull request #2361 was updated.

@iarspider iarspider force-pushed the indirect-changed-files branch from 405d178 to 5b5ff60 Compare October 29, 2024 14:02
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2024

Pull request #2361 was updated.

3 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024

Pull request #2361 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024

Pull request #2361 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

Pull request #2361 was updated.

@iarspider iarspider mentioned this pull request Nov 1, 2024
Closed
@iarspider iarspider marked this pull request as ready for review November 4, 2024 07:52
@iarspider iarspider force-pushed the indirect-changed-files branch from dd794e6 to 659cb94 Compare November 4, 2024 07:53
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

Pull request #2361 was updated.

@iarspider
Copy link
Contributor Author

iarspider commented Nov 4, 2024

@smuzaffar this PR is ready.

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 4, 2024

test parameters:

  • addpkg = FWCore

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 4, 2024

please test

@iarspider iarspider force-pushed the indirect-changed-files branch from 659cb94 to 263efda Compare November 4, 2024 11:45
@iarspider
Copy link
Contributor Author

iarspider commented Nov 11, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42725/summary.html
COMMIT: 35925f5
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2361/42725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343588
  • DQMHistoTests: Total failures: 422
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343146
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 13, 2024

please test for CMSSW_10_6_X

@iarspider
Copy link
Contributor Author

iarspider commented Nov 13, 2024

please test for CMSSW_10_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

Pull request #2361 was updated.

@iarspider
Copy link
Contributor Author

iarspider commented Nov 13, 2024

please test for CMSSW_10_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42813/summary.html
COMMIT: e5ca10a
CMSSW: CMSSW_10_6_X_2024-11-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2361/42813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215349
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 14, 2024

+externals

looks good

@smuzaffar smuzaffar merged commit 9bf8a73 into master Nov 14, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider deleted the indirect-changed-files branch November 14, 2024 09:12
@smuzaffar smuzaffar mentioned this pull request Nov 14, 2024
Merged
@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 14, 2024

@iarspider , looks like this broke the Pr tests. The static checks are running scram b clean which basically deletes allthe generated products. We need to either revert this or need a quick fix

@smuzaffar smuzaffar restored the indirect-changed-files branch November 14, 2024 12:57
@smuzaffar smuzaffar mentioned this pull request Nov 14, 2024
Merged
@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 20, 2024

@iarspider , we need to fix this

@smuzaffar smuzaffar deleted the indirect-changed-files branch November 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees

No one assigned

Labels

externals-approved fully-signed orp-pending tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iarspider @cmsbuild @smuzaffar