Skip to content

Conversation

@slava77
Copy link
Contributor

@slava77 slava77 commented Oct 31, 2021

this will catch up with changes in cms-sw/cmssw#35862

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 31, 2021

@cmsbuild please test with cms-sw/cmssw#35862,cms-sw/cmssw#35766

@srimanob
Copy link
Contributor

Thanks @slava77

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4d6e1/20122/summary.html
COMMIT: e8af8d0
CMSSW: CMSSW_12_2_X_2021-10-31-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1657/20122/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
135.4 step 1
136.8311 step 2
136.7611 step 2
136.88811 step 2
4.22 step 3
140.56 step 2
4.53 step 3
136.731 step 3
136.793 step 3
136.874 step 3
2018.1 step 1
1001.0 step 2
1000.0 step 2
1306.0 step 3
1330.0 step 3
312.0 step 3
10042.0 step 3
10024.0 step 3
10824.0 step 3
25202.0 step 3
11634.0 step 3
11634.7 step 3
11634.914 step 3
10224.0 step 3
11634.911 step 3
12434.0 step 3
23234.0 step 3
34634.0 step 3
38634.0 step 3
28234.0 step 3
250202.181 step 4
34834.999 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 22529 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 9
  • DQMHistoTests: Total histograms compared: 304467
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 304459
  • DQMHistoTests: Total skipped: 8
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
  • Checked 111 log files, 13 edm output root files, 9 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@cmsbuild please test with cms-sw/cmssw#35862,cms-sw/cmssw#35766

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4d6e1/20138/summary.html
COMMIT: e8af8d0
CMSSW: CMSSW_12_2_X_2021-10-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1657/20138/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2693404
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2693382
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 168 log files, 32 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor Author

slava77 commented Nov 1, 2021

it would be nice to get this in, before the tests start picking up CMSSW_12_2_X_2021-11-01-1100

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants