Skip to content

Conversation

@slava77
Copy link
Contributor

@slava77 slava77 commented Oct 27, 2021

11634.914 and 38634.0 were added in cms-sw/cmssw#35761 in CMSSW_12_1_X_2021-10-26-2300.

This PR should also resolve the warnings about missing mapping now appearing in the PR tests in 12_1_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 27, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c02d6/19990/summary.html
COMMIT: 4fc8421
CMSSW: CMSSW_12_1_X_2021-10-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1654/19990/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor Author

slava77 commented Oct 27, 2021

the warnings about a missing map are gone, and the directories with results for 11634.914 and 38634.0 now show up as expected in validateJR, and the log files look OK.

So, I think that this is ready to merge.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 41d6467 into cms-sw:master Oct 27, 2021
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants