Skip to content

Conversation

@smuzaffar
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters:

  • disable_poison = true

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#6777,cms-sw/root#153

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 1, 2021

@slava77 , as mentioned cms-sw/root#153 (comment), bot was only checking for extra merges when cmssw PRs are involved.
For non-cmssw PRs , we do not get extra merge commits. In this case bot just runs "git cms-addpkg packages` which checks out packages from the release tag (instead of release branch). So for non-cmssw PR tests there will be no extra merges checked out.

So, I think this change is not needed.

@smuzaffar smuzaffar closed this Apr 1, 2021
@slava77
Copy link
Contributor

slava77 commented Apr 1, 2021

@slava77 , as mentioned cms-sw/root#153 (comment), bot was only checking for extra merges when cmssw PRs are involved.
For non-cmssw PRs , we do not get extra merge commits. In this case bot just runs "git cms-addpkg packages` which checks out packages from the release tag (instead of release branch). So for non-cmssw PR tests there will be no extra merges checkout.

So, I think this change is not needed.

I'm not sure I followed the description above.
The symptom in cms-sw/root#153 was clear that a test was done with the head of cms-sw/cmsdist (not equal to the baseline IB).
Is your comment implying that there is no way to see the extra cms-sw/cmsdist merges in the test summary? (if I can do it manually, I'd guess that it can be done programmatically).

@smuzaffar
Copy link
Contributor Author

No, I was only talking about cmssw as currently bot is only looking for cmssw extra merges. We should be able to get the extra merges for cmsdist too.

@smuzaffar smuzaffar deleted the add-merge-commits branch April 1, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants