Substitute custom prefix scan with standard implementations #221
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| namespace clue::internal::algorithm { | ||
|
|
||
| template <typename InputIterator, typename OutputIterator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| } | ||
| if (active) | ||
| co[i] = x; | ||
| template <typename ExecutionPolicy, typename ForwardIterator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| ALPAKA_FN_ACC ALPAKA_FN_INLINE void warpPrefixScan( | ||
| const TAcc& acc, int32_t laneId, T* c, int32_t i, bool active = true) { | ||
| warpPrefixScan(acc, laneId, c, c, i, active); | ||
| template <typename InputIterator, typename OutputIterator, typename BinaryOperator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| for (int32_t i = 1; i < size; ++i) | ||
| co[i] = ci[i] + co[i - 1]; | ||
| } | ||
| template <typename ExecutionPolicy, typename ForwardIterator, typename BinaryOperator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| for (int32_t i = 1; i < size; ++i) | ||
| c[i] += c[i - 1]; | ||
| } | ||
| template <typename InputIterator, typename OutputIterator, typename BinaryOperator, typename T> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| ALPAKA_ASSERT_ACC(int(blocksPerGrid) == *pc); | ||
|
|
||
| // good each block has done its work and now we are left in last block | ||
| template <typename ExecutionPolicy, typename ForwardIterator, typename BinaryOperator, typename T> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| } | ||
| alpaka::syncBlockThreads(acc); | ||
| blockPrefixScan(acc, psum, psum, blocksPerGrid, ws); | ||
| template <typename InputIterator, typename OutputIterator, typename T> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| } | ||
| }; | ||
| } // namespace clue | ||
| template <typename ExecutionPolicy, typename ForwardIterator, typename T> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
|
|
||
| // declare the amount of block shared memory used by the multiBlockPrefixScan kernel | ||
| namespace alpaka::trait { | ||
| template <typename InputIterator, typename OutputIterator, typename T, typename BinaryOperator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| } | ||
| } | ||
| }; | ||
| template <typename ExecutionPolicy, typename ForwardIterator, typename T, typename BinaryOperator> |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 96.66% 96.79% +0.13%
==========================================
Files 43 49 +6
Lines 1978 1934 -44
Branches 71 70 -1
==========================================
- Hits 1912 1872 -40
+ Misses 66 62 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sbaldu
force-pushed
the
internal-thrust-prefix-scan
branch
from
d4392fd to
0fa85a5
Compare
sbaldu
added
priority: low
sbaldu
force-pushed
the
internal-thrust-prefix-scan
branch
from
0fa85a5 to
07bee6c
Compare
sbaldu
added
refactor
and removed
code-rework
|
Closed by #365 for cleanliness. |
sbaldu
added
duplicate
2 participants
No description provided.