OMTF configuration fix to use phase-2 values #1247

folguera · 2024-04-09T14:24:50Z

PR description:

This contains the required config files to load the correct OMTF configuration for Phase-2. This is built on top of #1241 and it requires cms-data/L1Trigger-L1TMuon#27 to be merged and downloaded inside L1Trigger/L1TMuon/data/omtf_data

PR validation:

First quick look at efficiencies look OK: https://folguera.web.cern.ch/L1T/2024_04_AR_Tests/V36nano_muons_test/object_performance/turnons/MuonTFsMatching_Eta_Pt15toInf_-999_V36nano_muons.png

…merge-topic

triggerDoctor · 2024-04-10T13:24:49Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -j 8`

triggerDoctor · 2024-04-10T13:32:36Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks`

I found no issues with the headers!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 check-headers`

triggerDoctor · 2024-04-10T13:32:51Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 2 files that did not meet formatting requirements:

L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-format-all`

triggerDoctor · 2024-04-10T13:40:08Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b runtests`

triggerDoctor · 2024-04-10T13:45:55Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!

Info	Value
return code	`1`
command	`eval` scramv1 runtime -sh `&& runTheMatrix.py --what upgrade -l 26834.78`

…es in the OMTF configs

folguera · 2024-04-10T14:39:25Z

Hi @aloeliger @epalencia, this seems to be ready now, from a quick look, the efficiency for GMT SA muons is recovered (running with more stats now) I'd appreciate is @kbunkow and @zhenbinwu could have a look as well. This superseeds #1241

triggerDoctor · 2024-04-10T15:33:08Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -j 8`

triggerDoctor · 2024-04-10T15:38:58Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks`

I found no issues with the headers!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 check-headers`

triggerDoctor · 2024-04-10T15:39:05Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-format-all`

triggerDoctor · 2024-04-10T15:43:13Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b runtests`

triggerDoctor · 2024-04-10T15:48:27Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!

Info	Value
return code	`1`
command	`eval` scramv1 runtime -sh `&& runTheMatrix.py --what upgrade -l 26834.78`

zhenbinwu · 2024-04-10T16:15:25Z

L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

      prompt.push_back(samuon);
-    else if (mu.hwPtUnconstrained() > 0)
+    }
+    if (mu.hwPtUnconstrained() > 0)  //Assume exculsive, need double check


Can you remove the old comments?

triggerDoctor · 2024-04-10T16:52:12Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -j 8`

triggerDoctor · 2024-04-10T17:00:06Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks`

I found no issues with the headers!

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 check-headers`

triggerDoctor · 2024-04-10T17:00:20Z

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 2 files that did not meet formatting requirements:

L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	`0`
command	`eval` scramv1 runtime -sh `&& scram b -k -j 8 code-format-all`

zhenbinwu · 2024-04-10T20:38:46Z

Unfortunately it is not working for me. It miss the xml file
edm::FileInPath unable to find file L1Trigger/L1TMuon/data/omtf_config/Patterns_ExtraplMB1nadMB2DTQualAndEtaFixedP_ValueP1Scale_t20_v1_SingleMu_iPt_and_OneOverPt_classProb17_recalib2_minDP0.xml anywhere in the search path.

I can't find it from the cms-data : https://github.com/cms-data/L1Trigger-L1TMuon/tree/master/omtf_config

folguera · 2024-04-10T20:39:54Z

You need to download the cms-data PR too, it’s on the first comment. El 10 abr 2024, a las 22:27, Zhenbin Wu ***@***.***> escribió: It doesn't work for me. I got the missing file error: edm::FileInPath unable to find file L1Trigger/L1TMuon/data/omtf_config/Patterns_ExtraplMB1nadMB2DTQualAndEtaFixedP_ValueP1Scale_t20_v1_SingleMu_iPt_and_OneOverPt_classProb17_recalib2_minDP0.xml anywhere in the search path. — Reply to this email directly, view it on GitHub<#1247 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFM4UZFWVV4CJ4GT6WF52DY4WOA3AVCNFSM6AAAAABF6V7HDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGM3TSMBWHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

aloeliger · 2024-04-11T10:24:34Z

The data files required by this PR have been added into the prototype explicitly with #1250

aloeliger · 2024-04-11T10:27:01Z

@folguera Given the time crunch, we're not going to spend too much time debating the nature of this here provided everything still compiles and we can run our commands. I think we can already go ahead and merge this. Please go ahead and open the PR to central CMSSW, and we'll merge this here.

folguera · 2024-04-11T11:16:22Z

@aloeliger @epalencia this PR requires #1196 to be merged to central before.

aloeliger · 2024-04-11T12:59:46Z

@folguera Can this be added to cms-sw#44557 then?

aloeliger · 2024-04-11T15:44:48Z

@folguera @zhenbinwu @epalencia @omiguelc I am going to merge this, #1250, and #1249 when I get back to my apartment in an hour or so. Are there any further expected muon fixes? Are we waiting for anything else to provide to the menu team?

cbotta · 2024-04-11T16:12:10Z

@folguera @zhenbinwu @omiguelc I would like to ask if all these PRs allow the Menu team to use the GMT Standalone collection for the Standalone prompt muon efficiencies/rates, and for the Standalone displaced muon efficiencies/rates. Thanks a lot for confirming.

@aloeliger : I think we still expect a PR to fix the GMT TkMuon efficiency at low pT

folguera · 2024-04-11T16:14:40Z

@cbotta YES, standalone muons, both prompt and (hopefully) displaced can be used by the menu team.

zhenbinwu · 2024-04-11T16:18:11Z

For this PR, the prompt OMTF looks OK. For the displaced OMTF, we need the experts to confirm the efficiency I saw. Thanks

zhenbinwu · 2024-04-11T17:16:43Z

Ok, please merge this PR for the SAMuon. Thanks

Add data files required by PR #1247

zhenbinwu · 2024-04-13T00:05:25Z

Hi, I have cherry-picked the recent PRs (#1228, #1239, #1249, #1251) to the GMT PR (cms-sw#44498), expect this one.

Part of this PR is in the Phase-2 OMTF PR (cms-sw#44557). So I will leave these commits to that PR.

aloeliger · 2024-04-22T11:24:13Z

@folguera For our records, I need to understand if this has ended up in a PR to CMSSW, and where it ended up finally. Is there a PR to CMSSW with these commits in them?

folguera · 2024-04-22T14:59:32Z

Not yet, we need to add them to cms-sw#44557

zhenbinwu · 2024-04-22T15:08:51Z

Since the OMTF PR need to be merged before the GMT PR, I think it would be more practical to split the changes of L1Trigger/L1TMuonOverlapPhase2/python/fakeOmtfParamsPhase2_cff.py and L1Trigger/L1TMuonOverlapPhase2/python/simOmtfPhase2Digis_extrapol_cfi.py to the OMTF PR, L1Trigger/Configuration/python/SimL1Emulator_cff.py and L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc to the GMT PR.

I can just commit the changes to the GMT branch, dropping Santi's commit history, if that is OK.

folguera · 2024-04-22T15:11:41Z

Sounds good El 22 abr 2024, a las 17:09, Zhenbin Wu ***@***.***> escribió: Since the OMTF PR need to be merged before the GMT PR, I think it would be more practical to split the changes of L1Trigger/L1TMuonOverlapPhase2/python/fakeOmtfParamsPhase2_cff.py and L1Trigger/L1TMuonOverlapPhase2/python/simOmtfPhase2Digis_extrapol_cfi.py to the OMTF PR, L1Trigger/Configuration/python/SimL1Emulator_cff.py and L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc to the GMT PR. I can just commit the changes to the GMT branch, dropping Santi's commit history, if that is OK. — Reply to this email directly, view it on GitHub<#1247 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFM4U6AFDQ3BBCYMZ7VJ7LY6URZVAVCNFSM6AAAAABF6V7HDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZHAYTMNJSGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

epalencia · 2024-05-15T07:18:55Z

@zhenbinwu, was this fixed finally ported to CMSSW? If so, where?

zhenbinwu · 2024-05-15T14:09:11Z

@zhenbinwu, was this fixed finally ported to CMSSW? If so, where?

Yes, part of this PR was added to GMT PR cms-sw@642efa5

I think the OMTF part are merged in CMSSW as well.

Zhenbin Wu and others added 3 commits April 7, 2024 18:12

Fix bugs in phi conversion for FwdMuons

73eefa6

Merged phase2-l1t-1400pre3_v6_GMT from repository zhenbinwu with cms-…

13adc69

…merge-topic

OMTF config fix to use the Phase-2 configuration

81915a9

folguera added 2 commits April 10, 2024 16:07

fix conversion units in the convertL1Muon for the OMTF, minimal chang…

f8f2fef

…es in the OMTF configs

code format changes

994eb88

folguera marked this pull request as ready for review April 10, 2024 14:36

epalencia mentioned this pull request Apr 10, 2024

Fix bugs in Phi conversion for Phase-2 GMT SAMuons #1241

Closed

store all the OMTF candidates if hwPtUnconstrained() > 0

a7017eb

zhenbinwu reviewed Apr 10, 2024

View reviewed changes

remove old comment

3610ca3

aloeliger mentioned this pull request Apr 11, 2024

Add data files required by PR #1247 #1250

Merged

aloeliger added Phase-2 Pertains to phase-2 development Bug fix For minor bug fixing PRs labels Apr 11, 2024

aloeliger merged commit 5fb1ece into cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3 Apr 11, 2024

aloeliger added a commit that referenced this pull request Apr 11, 2024

Add data files required by PR #1247

b8c7446

aloeliger added a commit that referenced this pull request Apr 11, 2024

Merge pull request #1250 from aloeliger/1247_data

f1b2c4e

Add data files required by PR #1247

zhenbinwu mentioned this pull request Apr 22, 2024

Phase2 OMTF emulator cms-sw/cmssw#44557

Merged

OMTF configuration fix to use phase-2 values #1247

OMTF configuration fix to use phase-2 values #1247

Uh oh!

Conversation

folguera commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

folguera commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

zhenbinwu Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

triggerDoctor commented Apr 10, 2024

Uh oh!

zhenbinwu commented Apr 10, 2024

Uh oh!

folguera commented Apr 10, 2024 via email

Uh oh!

aloeliger commented Apr 11, 2024

Uh oh!

aloeliger commented Apr 11, 2024

Uh oh!

folguera commented Apr 11, 2024

Uh oh!

aloeliger commented Apr 11, 2024

Uh oh!

aloeliger commented Apr 11, 2024

Uh oh!

cbotta commented Apr 11, 2024

Uh oh!

folguera commented Apr 11, 2024

Uh oh!

zhenbinwu commented Apr 11, 2024

Uh oh!

zhenbinwu commented Apr 11, 2024

Uh oh!

zhenbinwu commented Apr 13, 2024

Uh oh!

aloeliger commented Apr 22, 2024

Uh oh!

folguera commented Apr 22, 2024

Uh oh!

zhenbinwu commented Apr 22, 2024

Uh oh!

folguera commented Apr 22, 2024 via email

Uh oh!

epalencia commented May 15, 2024

Uh oh!

zhenbinwu commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

folguera commented Apr 9, 2024 •

edited

Loading