Skip to content

Conversation

@cgsavard
Copy link

PR description:

This PR updates the displaced track cuts to only use variables available in the track word. The main swap is to use chi2rz/dof and chi2rphi/dof instead of chi2/dof. More on the swapping of the cuts can be seen in the GTT presentation here

PR validation:

Checks were made to test the jet efficiency before and after swapping the displaced jet cuts and see no significant change, as can be seen below:
image

All code checks were performed.

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1TTrackMatch/plugins/L1TrackJetClustering.h

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@aloeliger
Copy link

@epalencia I don't think there's really any review from my side on this. Anything from you? If not, @cgsavard Please open this PR up to main CMSSW if it hasn't been already.

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Configuration labels Jan 12, 2024
@epalencia
Copy link

I confirm @cgsavard can go ahead and open the corresponding PR in master

@aloeliger
Copy link

ping @cgsavard. Has this been opened to CMSSW? If it has, could you please reference the CMSSW PR # here?

@cgsavard
Copy link
Author

The PR into CMSSW has been created cms-sw#43737

@aloeliger aloeliger added the Physics Affecting A PR expected to affect Physics content of the trigger label Jan 22, 2024
@epalencia epalencia merged commit f2d571a into cms-l1t-offline:phase2-l1t-integration-13_3_0_pre3 Jan 25, 2024
@epalencia
Copy link

Tagged as phase2-l1t-1330pre3_v15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Configuration Phase-2 Pertains to phase-2 development Physics Affecting A PR expected to affect Physics content of the trigger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants