-
Notifications
You must be signed in to change notification settings - Fork 26
Updated correlator layer 1 e/gamma sorter #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated correlator layer 1 e/gamma sorter #1129
Conversation
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no files with code format issues!
|
|
Hi, |
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no files with code format issues!
|
|
Tagged as |
PR description:
This PR implements a new sorter of e/gamma objects based on iterative merge-sort, to be used in the barrel part of the correlator layer 1.
Currently in CMSSW both the barrel and the endcaps were configured to use the sorter based on iterative insertion sort, but in the barrel that sorter can't be implemented in firmware as there aren't enough clock cycles to sort all objects.
From a CMSSW point of view the only change this PR may make in the output is that objects with the same pT may end up in different order in the output collection.
The new sorter was checked against the old one, and validated against the firmware implementation of the same algorithm in HLS (and against the output of running the firmware algorithm on a board at b904)
The PR to CMSSW master is cms-sw#41727