Skip to content

Conversation

@gpetruc
Copy link

@gpetruc gpetruc commented May 18, 2023

PR description:

This PR implements a new sorter of e/gamma objects based on iterative merge-sort, to be used in the barrel part of the correlator layer 1.
Currently in CMSSW both the barrel and the endcaps were configured to use the sorter based on iterative insertion sort, but in the barrel that sorter can't be implemented in firmware as there aren't enough clock cycles to sort all objects.

From a CMSSW point of view the only change this PR may make in the output is that objects with the same pT may end up in different order in the output collection.

The new sorter was checked against the old one, and validated against the firmware implementation of the same algorithm in HLS (and against the output of running the firmware algorithm on a board at b904)

The PR to CMSSW master is cms-sw#41727

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no files with code format issues!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR labels May 24, 2023
@gpetruc
Copy link
Author

gpetruc commented May 24, 2023

Hi,
Thanks for merging #1096.
I've solved the conflicts after the merge and pushed the updates to this PR.

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no files with code format issues!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@epalencia epalencia merged commit d5b6578 into cms-l1t-offline:phase2-l1t-integration-1252patch1 May 31, 2023
@epalencia
Copy link

Tagged as l1t-phase2-v66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emulator Development Emulator development PR Phase-2 Pertains to phase-2 development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants