add default ctor and reset method to ModelLoader
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@missirol Could you also create a PR for |
Author
|
Okay, this is in cms-sw/cmsdist#9606. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to the
ModelLoaderclass.resetmethod to be used to (a) close the open shared library if needed, and (b) specify the name of a new shared library to be loaded.".so"to the library name to theload_modelmethod, so that the new methodmodel_name()returns the model name specified in ctor orreset.Makefileso that runningmake cleanmultiple times in a row does not lead to an error.Backward compatible, and necessary for cms-sw/cmssw#47070 (see cms-sw/cmssw#46740).