Updates from Igrof master for Ubuntu which might help with EL8 by gartung · Pull Request #5 · cms-externals/igprof

gartung · 2022-12-05T21:14:33Z

I want to test to see if this helps with memory undercounting on EL8.

GCC 7 (r244326) complains about comparing two function pointers with different singatures on src/profile.cc:580:24 src/profile.cc: In function 'bool igprof_init(const char*, void (*)(), bool, double)': src/profile.cc:580:24: error: comparison between distinct pointer types 'void (*)() __attribute__((noreturn))' and 'void (*)() throw ()' lacks a cast [-fpermissive] if (igprof_abort != &abort) ^~~~~ Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

GCC 7 (r244326) complains that we reach end of function with non-void return. Add __builtin_unreachable right after abort function to tell compiler that any code after abort is not possible. Alternatively we could return 0x0/NULL after abort. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

gartung · 2022-12-05T21:14:51Z

enable profiling

cmsbuild · 2022-12-05T21:14:57Z

A new Pull Request was created by @gartung (Patrick Gartung) for branch cms/master/c6882f4.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2022-12-05T21:26:38Z

Pull request #5 was updated.

cmsbuild · 2022-12-06T05:17:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/29469/summary.html
COMMIT: 679924e
CMSSW: CMSSW_13_0_X_2022-12-05-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/igprof/5/29469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3421337
DQMHistoTests: Total failures: 152
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3421163
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 206 log files, 158 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-12-06T09:33:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/29468/summary.html
COMMIT: 679924e
CMSSW: CMSSW_13_0_X_2022-12-05-1100/slc7_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/igprof/5/29468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 62347 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3421337
DQMHistoTests: Total failures: 121015
DQMHistoTests: Total nulls: 229
DQMHistoTests: Total successes: 3300071
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.10599999999999987 KiB( 47 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.469 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): 1.482 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.053 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.488 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.492 KiB SiStrip/MechanicalView
Checked 206 log files, 158 edm output root files, 48 DQM output files
TriggerResults: found differences in 17 / 46 workflows

gartung · 2022-12-06T16:57:23Z

The undercounting still exists for cpu performance.

sprintf is marked as deprecated under XCode 13, resulting in compiler errors due to the stricted options we use. We move everything to use snprintf to silence the warning and maybe avoid some buffer overrun.

gartung · 2023-01-27T17:49:30Z

please test with cms-sw/cmsdist#8269

gartung · 2023-01-27T17:50:06Z

please test with cms-sw/cmsdist#8269 for slc7_amd64_gcc11

cmsbuild · 2023-01-27T20:38:25Z

Pull request #5 was updated.

smuzaffar · 2023-01-27T22:17:16Z

please test with cms-sw/cmsdist#8269

smuzaffar · 2023-01-27T22:17:37Z

please test with cms-sw/cmsdist#8269 for slc7_amd64_gcc11

cmsbuild · 2023-01-28T01:52:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/30214/summary.html
COMMIT: 66805e0
CMSSW: CMSSW_13_0_X_2023-01-27-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/igprof/5/30214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555467
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-01-28T07:54:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/30215/summary.html
COMMIT: 66805e0
CMSSW: CMSSW_13_0_X_2023-01-27-1100/slc7_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/igprof/5/30215/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 65374 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 156946
DQMHistoTests: Total nulls: 272
DQMHistoTests: Total successes: 3398255
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.32 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.469 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11834.0 ): -1.732 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.053 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.488 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -2.492 KiB SiStrip/MechanicalView
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: found differences in 18 / 47 workflows

Conflicts: src/hook.cc

cmsbuild · 2023-01-31T13:31:40Z

Pull request #5 was updated.

gartung and others added 6 commits September 1, 2020 17:19

Don't remove /1 unless it is at the end of the url. (igprof#84)

03d16c1

Create README.md

7a3168c

Handle ENDBR64 instruction (igprof#91)

e630848

Fix to work on Ubuntu 18.4 and subsequent ones

58942b6

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Dec 5, 2022

cmsbuild added tests-started tests-pending and removed tests-pending tests-started labels Dec 5, 2022

gartung changed the title ~~Revert changes made to deal with TBB resumable tasks.~~ Revert changes made to deal with TBB resumable tasks and updates from Igrof master for Ubuntu. Dec 5, 2022

cmsbuild added tests-started and removed tests-pending labels Dec 5, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 6, 2022

gartung closed this Dec 6, 2022

Handle sprintf depreation

4fb2ccf

sprintf is marked as deprecated under XCode 13, resulting in compiler errors due to the stricted options we use. We move everything to use snprintf to silence the warning and maybe avoid some buffer overrun.

gartung reopened this Dec 6, 2022

cmsbuild added requires-external and removed tests-approved labels Dec 6, 2022

cmsbuild added the requires-external label Jan 27, 2023

cmsbuild added tests-started tests-pending and removed tests-rejected tests-started requires-external labels Jan 27, 2023

cmsbuild added requires-external tests-started and removed tests-pending labels Jan 27, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2023

gartung mentioned this pull request Jan 28, 2023

Remove patch that does not work with head of Igprof/master cms-sw/cmsdist#8269

Merged

gartung closed this Jan 28, 2023

gartung reopened this Jan 28, 2023

gartung added 3 commits January 31, 2023 14:29

Merge remote-tracking branch 'igprof/master' into cms/master/c6882f4

de59141

Conflicts: src/hook.cc

Add patch

3f8d5bc

Use libjemalloc.so.2

58ad5c8

gartung force-pushed the cms/master/c6882f4 branch from 66805e0 to 58ad5c8 Compare January 31, 2023 13:31

cmsbuild added tests-pending and removed tests-approved requires-external labels Jan 31, 2023

gartung merged commit a505ed3 into cms-externals:cms/master/c6882f4 Jan 31, 2023

Conversation

gartung commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gartung commented Dec 5, 2022

Uh oh!

cmsbuild commented Dec 5, 2022

Uh oh!

cmsbuild commented Dec 5, 2022

Uh oh!

cmsbuild commented Dec 6, 2022

Comparison Summary

Uh oh!

cmsbuild commented Dec 6, 2022

Comparison Summary

Uh oh!

gartung commented Dec 6, 2022

Uh oh!

gartung commented Jan 27, 2023

Uh oh!

gartung commented Jan 27, 2023

Uh oh!

cmsbuild commented Jan 27, 2023

Uh oh!

smuzaffar commented Jan 27, 2023

Uh oh!

smuzaffar commented Jan 27, 2023

Uh oh!

cmsbuild commented Jan 28, 2023

Comparison Summary

Uh oh!

cmsbuild commented Jan 28, 2023

Comparison Summary

Uh oh!

cmsbuild commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gartung commented Dec 5, 2022 •

edited

Loading